Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename Nirmala_Ramnarine_BCO_000537.json to Updated_Nirmal… #195

Merged
merged 2 commits into from
Oct 17, 2019

Conversation

nramnarine
Copy link
Contributor

…a_Ramnarine_BCO_000537.json

Ready for Final Review

…a_Ramnarine_BCO_000537.json

Ready for Final Review
@jpat1546
Copy link
Collaborator

jpat1546 commented Oct 17, 2019

@nramnarine Reassigning back to you; please add the appropriate tags to this pull request. See assignment details. Once they are added, reassign me and I will review your final BCO.Thanks.

@nramnarine
Copy link
Contributor Author

Okay, I placed the correct tags. Thank you Janisha!

Copy link
Collaborator

@jpat1546 jpat1546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nramnarine

I've reviewed your updated BCO and made comments on what further needs to be fixed (minor changes).

Please make all the changes in the BCO Editor, download, and update this pull request file with the new JSON (copy/paste- same process as before). Once all changes have been made, assign this pull request back to me and I will review again. Until then, assigning the pull request back to you.

Great job with those modifications!

Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
Student_BCOs/Updated_Nirmala_Ramnarine_BCO_000537.json Outdated Show resolved Hide resolved
@jpat1546 jpat1546 removed their assignment Oct 17, 2019
Ready for review before PrecisionFDA submission
Copy link
Collaborator

@jpat1546 jpat1546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your BCO is approved

Great job fixing all your assigned issues, @nramnarine .

Prior to submitting to the pFDA challenge, please make the following 2 changes to your BCO in the BCO Editor (then download and submit to the pFDA):
In Provenance domain:

  • Change reviewer status from "in review" to "approved"
  • Change reviewer_comment from "Reviewed by BioCompute technical assistant, approval pending modification by author" to "Reviewed and approved by BioCompute technical assistant"

Leave me a comment if these instructions are not clear. Thanks!

@jpat1546 jpat1546 merged commit 90290cf into master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants