Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore dexseq python helper scripts #12352

Merged
merged 5 commits into from
Nov 29, 2018
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion recipes/bioconductor-dexseq/build.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
#!/bin/bash
mv DESCRIPTION DESCRIPTION.old
grep -v '^Priority: ' DESCRIPTION.old > DESCRIPTION
$R CMD INSTALL --build .
$R CMD INSTALL --build .
python_scripts=$PREFIX/lib/R/library/DEXSeq/python_scripts
sed -i.bak '1s|^|#!/usr/bin/env python\'$'\n|g' $python_scripts/dexseq_count.py
sed -i.bak '1s|^|#!/usr/bin/env python\'$'\n|g' $python_scripts/dexseq_prepare_annotation.py
if [ "$PY3K" == 1 ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try: if [ $PY3K -eq 1 ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, and added set -x to the build script. Seems that $PY3K is set to 0, and thus the 2to3 commands are skipped. I'm going to try adding python to the host section of the meta.yaml file to see if that sets $PY3K.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that didn't work either. $PY3K remains set to 0. Perhaps that is broken or not the correct way to detect that we're building against Python 3? The documentation regarding build variables is a bit vague:

PY3K | 1 when Python 3 is installed in the build prefix, otherwise 0.

Perhaps using $PY_VER is more appropriate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... $PY_VER is clearly set to 2.7... Looking at the build output, it seems that python 2.7 is used during the build, but that python 3.6 is used when installed and tested. Is there a way to force these to be the same version?

2to3 -w $python_scripts/dexseq_count.py
2to3 -w $python_scripts/dexseq_prepare_annotation.py
fi
chmod +x $python_scripts/dexseq_count.py
chmod +x $python_scripts/dexseq_prepare_annotation.py
mkdir -p $PREFIX/bin
ln -s $python_scripts/dexseq_count.py $PREFIX/bin/dexseq_count.py
ln -s $python_scripts/dexseq_prepare_annotation.py $PREFIX/bin/dexseq_prepare_annotation.py
12 changes: 11 additions & 1 deletion recipes/bioconductor-dexseq/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,21 @@
package:
name: 'bioconductor-{{ name|lower }}'
version: '{{ version }}'

source:
url:
- 'http://bioconductor.org/packages/{{ bioc }}/bioc/src/contrib/{{ name }}_{{ version }}.tar.gz'
- 'https://bioarchive.galaxyproject.org/{{ name }}_{{ version }}.tar.gz'
- 'https://depot.galaxyproject.org/software/bioconductor-{{ name|lower }}/bioconductor-{{ name|lower }}_{{ version }}_src_all.tar.gz'
sha256: e1e9026c07fc26e1eaee06a0dd63d2f765bcd711f350fdb2a2236ad65b1d0bd7

build:
number: 0
noarch: python
number: 1
rpaths:
- lib/R/lib/
- lib/

requirements:
host:
- 'bioconductor-annotationdbi >=1.42.1,<1.44.0'
Expand Down Expand Up @@ -55,13 +59,19 @@ requirements:
- r-rcolorbrewer
- r-statmod
- r-stringr
- python <3

test:
commands:
- '$R -e "library(''{{ name }}'')"'
- dexseq_count.py --help
- dexseq_prepare_annotation.py --help

about:
home: 'http://bioconductor.org/packages/{{ bioc }}/bioc/html/{{ name }}.html'
license: 'GPL (>= 3)'
summary: 'The package is focused on finding differential exon usage using RNA-seq exon counts between samples with different experimental designs. It provides functions that allows the user to make the necessary statistical tests based on a model that uses the negative binomial distribution to estimate the variance between biological replicates and generalized linear models for testing. The package also provides functions for the visualization and exploration of the results.'

extra:
identifiers:
- biotools:dexseq