Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEXSeq - resolve HTSeq/numpy depenency version mismatch #12468

Closed

Conversation

lparsons
Copy link
Contributor

@lparsons lparsons commented Dec 3, 2018

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

I've pinned the version of numpy used for HTSeq in #12467. However, since this requires an older htseq recipe that doesn't have numpy properly pinned, I'm forcing it here. These can be removed when we get various fixes from DEXSeq upstream areyesq89/DEXSeq#1.

@lparsons lparsons requested a review from dpryan79 December 3, 2018 21:07
@lparsons
Copy link
Contributor Author

lparsons commented Dec 4, 2018

Just wondering if this approach is kosher, or if there is a better way to fix this (fixing old HTSeq version(s)?). Ping @bgruening and @dpryan79 since you guys seem like gurus... 😉

@dpryan79
Copy link
Contributor

dpryan79 commented Dec 4, 2018

I never get the numpy pinning stuff right, so I'll defer to Björn :)

@lparsons
Copy link
Contributor Author

lparsons commented Dec 4, 2018

Well @epruesse merged the HTSeq fix in #12467. However:

  1. I don't really have a way to test that it works
  2. At best, it applied to the latest HTSeq (0.11), but that won't help for DEXSeq since it requires an older version (<0.10).

@bgruening
Copy link
Member

bgruening commented Dec 4, 2018

@lparsons can we not fix the old htseq-count recipe for 0.9.1.

@lparsons
Copy link
Contributor Author

lparsons commented Dec 4, 2018

@bgruening I don't think I follow you. Are you saying we cannot fix the old HTSeq? Can you tell me:

  1. Is requiring a specific numpy version and specific HTSeq version for DEXSeq the best way to make DEXSeq actually work? Since DEXSeq requires an old HTSeq version, this was the best way found to (hopefully) fix it.

  2. Is the way I pinned numpy for HTSeq sufficient to fix the current version of HTSeq

@bgruening
Copy link
Member

@lparsons I think we should fix the old htseq-count recipe.

Is requiring a specific numpy version and specific HTSeq version for DEXSeq the best way to make DEXSeq actually work? Since DEXSeq requires an old HTSeq version, this was the best way found to (hopefully) fix it.

It has a good chance to fix it. But I would prefer to fix htseq-count 0.9.1 instead.

Is the way I pinned numpy for HTSeq sufficient to fix the current version of HTSeq

I don't know, probably. We should use - {{ pin_compatible('numpy') }} in run dependencies if we can, but this is only working when you have host dependencies as well.

@lparsons
Copy link
Contributor Author

lparsons commented Dec 4, 2018 via email

@bgruening
Copy link
Member

That sounds alright to me :)

@lparsons
Copy link
Contributor Author

lparsons commented Dec 5, 2018

OK, submitted #12490 which should hopefully resolve this. Once tested I'll update/delete this as needed.

@lparsons
Copy link
Contributor Author

lparsons commented Dec 5, 2018

I believe that #12490 has eliminated the need for this PR, closing.

@lparsons lparsons closed this Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants