-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add igphyml #18945
Add igphyml #18945
Conversation
Xref: #18930 |
@bioconda-bot please fetch artifacts |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
@PertuyF Can you see if this works? I'm not entirely sure how this program will work since it really does hardcode the exact path to the motifs in the source code. I've tried making that relative to where the binary is, but I'm suspecting that that won't work and that the source code will have to get modified. That's probably also the only way to make relocatable binaries like would be needed for a conda install. |
@dpryan79 binary works OK, but we're missing the And for Linux version I get a warning when setting Unfortunately I can't access a machine to test OSX version. |
I'm amazed that works at all. I guess this needs an activation script. The OMP thing just needs a new |
* Use sequences from example.fasta * Use minimum number of 3 entries * Include root sequence ID from doc examples for consistency
* Test binary is built with OpenMP * Test hotspot tables are found with `IGPHYML_PATH` env var
For some reason my test file wasn't included for final test phase. Although I think I followed the doc. Can be OK to use these files to run tests, but I can also include my |
There is something wrong with tests during mulled-build. Do you have a clue @dpryan79 ? |
Test files don't make it into the container for testing, since they're not part of the end package (just the recipe). For the mulled tests there's just a binary being called, so the activation scripts are never run. |
Good job, this looks cleaner! Next step will be Blas support :) |
@PertuyF Go ahead and approve this PR and then merge it with |
@bioconda-bot please merge |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
I received an error uploading the build artifacts or merging the PR! |
Meh, normal merge it is then. |
It seems there are some networking issues that borked the bot's upload. We'll just use the regular CI then to upload things. |
Good for me, as long as the package is released! |
Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the
please review & merge
label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping@bioconda/core
so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.