Blacklist update #18992
Blacklist update #18992
Conversation
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # download the databases required by several options | |||
| $PREFIX/bin/download-antismash-databases | |||
There was a problem hiding this comment.
Did it fail with the $PREFIX/bin/ in place? IIRC, older conda versions (<4.6) did not activate the environment. But PREFIX should be available in the script, no matter which conda version.
There was a problem hiding this comment.
It seems to have failed then, yes.
There was a problem hiding this comment.
The link scripts are very awkward in general... Since the previous version with PREFIX would not have worked reliably for conda <4.6 users, I'm okay with this change. (If the users run the install in an already activated environment, everything should be fine.)
|
@bioconda-bot please merge |
|
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
|
I received an error uploading the build artifacts or merging the PR! |
|
@bioconda-bot please merge |
|
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
|
Sorry bot, you're taking too long. |
|
Whoa, https://quay.io/repository/biocontainers/antismash?tag=latest&tab=tags
that's a fat one, no wonder! |
|
I received an error uploading the build artifacts or merging the PR! |
|
Yeah, I think we should update the timeout to 30 minutes, or maybe even an hour. I bet the container doesn't get uploaded by the master branch either. |
Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the
please review & mergelabel so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping@bioconda/coreso that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.