-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More blacklist updates #18999
More blacklist updates #18999
Conversation
@bioconda-bot please fetch artifacts |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
@bioconda-bot please add label |
@@ -7,6 +7,8 @@ package: | |||
source: | |||
url: https://pypi.io/packages/source/G/GroopM/GroopM-{{ version }}.tar.gz | |||
sha256: 48bdaeb9010e7d81785697a55edc394ef36c2646b310d625a24bec740f1b6080 | |||
patches: | |||
- patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should better use MPLBACKEND=Agg
in the tests than patching this in, right?
Something like this:
test:
commands:
- MPLBACKEND=Agg python -c 'import groopm'
- MPLBACKEND=Agg groopm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, since we need it to run everywhere and it'll fail on most clusters and in containers at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the reasoning, but I don't agree. It's up to the user to set it. Or, in rarer cases, up to the upstream developers to decide. We should only patch it if it's not maintained upstream anymore and there is a clear intend to only want the Agg
backend.
No matter the decision on the above, it most likely makes sense to change the dependency from matplotlib
to matplotlib-base
in all cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A compromise would be to scan the env and if nothing is in there fallback to Agg? This would provide people a way to overwrite our defaults.
Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the
please review & merge
label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping@bioconda/core
so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.