Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update savana to 1.0.4 (Resolve errors by pinning scikit-learn to 1.2.x) #42859

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Update savana to 1.0.4 (Resolve errors by pinning scikit-learn to 1.2.x) #42859

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d627dc5
using run_exports to pin 1.2.x for scikit-learn (known breakage)
helrick Sep 6, 2023
10b0b8d
moving run_exports directly under build, bumping version to satisfy l…
helrick Sep 6, 2023
98de52c
correcting pin_subpackage run_export, re-pin scikit-learn
helrick Sep 6, 2023
d202ccb
Merge branch 'master' into fix/savana
helrick Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions recipes/savana/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{% set name = "savana" %}
{% set version = "1.0.3" %}
{% set version = "1.0.4" %}

package:
name: "{{ name }}"
version: "{{ version }}"

source:
url: "https://github.com/cortes-ciriano-lab/{{ name }}/archive/{{ version }}.tar.gz"
sha256: 803554f7efbba397e2cf9c1eee04f8471606ab4029b4eacf59ae34463ff2521d
sha256: f870ec9d36b20c1caf7849a4bff7af8cc984cd076b2f4d39153661e15776c644

build:
number: 0
Expand All @@ -16,6 +16,8 @@ build:
- "{{ PYTHON }} -m pip install . -vv"
entry_points:
- savana=savana.savana:main
run_exports:
- {{ pin_subpackage(name, max_pin="x") }}

requirements:
build:
Expand All @@ -25,7 +27,7 @@ requirements:
- pybedtools >=0.9.0
- pysam >=0.20.0
- cyvcf2 >=0.30.16
- scikit-learn >=1.2.2
- scikit-learn >=1.2.2,<1.3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dpryan79 I've just tested installing the newly merged 1.0.4 version of savana, with both conda and mamba, but version 1.3.0 of scikit-learn is still being installed though I've tried to pin it below 1.3.0 in the meta.yaml here. Would you be able to advise how best to pin the version of a dependency? Many thanks.

- pandas >=2.0.0
- matplotlib-base >=3.7.1

Expand Down