Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azimuth and dependencies #45914

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Add azimuth and dependencies #45914

merged 5 commits into from
Mar 15, 2024

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Feb 20, 2024

Describe your pull request here

Adds azimuth package, a Shiny app demonstrating a query-reference mapping algorithm for single-cell data.

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 23, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Feb 23, 2024
@daler
Copy link
Member

daler commented Feb 25, 2024

@isuruf couple of comments.

First, Seurat (r-seurat) is maintained over on conda-forge. My best guess would be that's to support Windows users (since bioconda does not build on windows). So any closely-associated packages, like seurat-data and seurat-disk but also likely azimuth should probably also be maintained over there. For example r-seuratobject is closely related and maintained over there.

Second, by convention, R packages take an r- prefix to the name. So these should at least be r-azimuth, r-immunogenomics-presto, r-seurat-data, and r-seurat-disk.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 26, 2024

Since azimuth uses bioconductor packages, I think it should stay here in bioconda. Otherwise a bunch of bioconductor packages will need to be moved over to conda-forge.

As to seurat-data, seurat-disk and presto, these are not CRAN packages and I thought that the r- prefix was used only for CRAN packages. Let me know if that's not the case and I'll fix those. (conda-forge currently has only CRAN packages I think. I'll check)

@isuruf
Copy link
Contributor Author

isuruf commented Mar 5, 2024

Ping on this @daler

@bgruening
Copy link
Member

I hope it's ok to jump in here.

I'm not sure we ever had such a strict rule of cran packages going to r- namespace and everything else doesn't, especially because many packages move to cran later when they have been shipped via conda.
What we did instead is (I think) naming all pure R packages r-. And this classifies here for your Seurat packages.

I agree that azimuth needs to stay here as it has a Bioconductor dependency.
That said, my feeling is that both Seurat packages should move to conda-forge to stay consistent. The others can stay here. But really, as we have no strict rules here, and if you want to maintain them here, I'm also fine with that and we can move them later if the need arises.

@isuruf
Copy link
Contributor Author

isuruf commented Mar 14, 2024

I have add the r- prefix to all 4 packages. I would prefer to maintain them here as it would be easier to update them together. The two seurat pacakges and azimuth are by the same author and the two seurat packages are used only in azimuth AFAIK.

about:
home: https://mojaveazure.github.io/seurat-disk/
dev_url: https://github.com/mojaveazure/seurat-disk
license: GPL-3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please use here SPDX identifiers

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we could use SPDX IDs that would be ace.

@bgruening bgruening enabled auto-merge (squash) March 15, 2024 15:56
@bgruening bgruening merged commit 5eeac55 into bioconda:master Mar 15, 2024
5 checks passed
@isuruf
Copy link
Contributor Author

isuruf commented Mar 15, 2024

Thanks @bgruening and @daler

@isuruf isuruf deleted the azimuth branch March 15, 2024 20:44
@bgruening
Copy link
Member

Thanks too you for everything you did theast years for the OS community!

martin-g pushed a commit to martin-g/bioconda-recipes that referenced this pull request Mar 18, 2024
* Add azimuth and dependencies

* Use github archives and add run_exports

* fix run_exports

* rename to have r- prefix

* SPDX
Tim15-tech pushed a commit to Tim15-tech/bioconda-recipes that referenced this pull request Mar 18, 2024
* Add azimuth and dependencies

* Use github archives and add run_exports

* fix run_exports

* rename to have r- prefix

* SPDX
Tim15-tech pushed a commit to Tim15-tech/bioconda-recipes that referenced this pull request Apr 3, 2024
* Add azimuth and dependencies

* Use github archives and add run_exports

* fix run_exports

* rename to have r- prefix

* SPDX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants