smalt: add aarch64/arm64 builds #51104
Conversation
martin-g
added
aarch64
|
Warning Rate limit exceeded@martin-g has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 35 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
recipes/smalt/meta.yaml (2)
6-7: LGTM! Consider using SHA256 instead of MD5.The addition of the source URL and checksum is correct and matches the package version. However, consider using SHA256 instead of MD5 for improved security, as MD5 is considered cryptographically weak.
Line range hint
14-29: Consider updating Python requirement.While not part of the current changes, it's worth noting that this package requires Python 2.6 or higher but less than 3. Given that Python 2 is no longer supported, consider updating the package to support Python 3 if possible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/smalt/meta.yaml (2 hunks)
🔇 Additional comments (1)
recipes/smalt/meta.yaml (1)
38-40: LGTM! Verify build process for new platforms.The addition of linux-aarch64 and osx-arm64 platforms aligns with the PR objective. This will allow the package to be built for ARM-based systems, increasing its compatibility.
To ensure the package can be built correctly for these new platforms, please verify:
- The build process on these platforms.
- Any platform-specific dependencies or configurations needed.
You may want to run test builds on these platforms to confirm everything works as expected.
| number: 3 | ||
| run_exports: | ||
| - {{ pin_subpackage('smalt', max_pin="x.x") }} |
There was a problem hiding this comment.
💡 Codebase verification
Based on the search results, it's clear that the changes to the smalt package could potentially impact multiple other packages. Specifically, biotradis, iva, quatradis, and shiver all list smalt as a dependency in their meta.yaml files.
Recommendation: Carefully review the changes made to smalt and consider testing the dependent packages.
Given the widespread use of smalt as a dependency, it's crucial to ensure that the changes made don't introduce any breaking changes or unexpected behavior in the dependent packages. Consider the following steps:
- Review the specific changes made to the smalt package.
- Test the dependent packages (biotradis, iva, quatradis, and shiver) with the updated smalt version to ensure compatibility.
- If possible, communicate with the maintainers of these dependent packages to inform them of the changes and encourage testing.
This approach will help maintain the stability of the ecosystem and prevent potential issues down the line.
🔗 Analysis chain
LGTM! Consider clarifying the run_exports pinning.
The build number increment is correct. The addition of run_exports is a good practice for ensuring compatibility with downstream recipes. However, consider clarifying why the max_pin is set to "x.x". Is this based on the package's versioning scheme or known compatibility issues?
To verify the impact of this change, let's check for any recipes that depend on smalt:
To properly assess the impact of the changes to the smalt package, I need to check if other packages directly depend on it. I'll search for smalt dependencies in the identified meta.yaml files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for recipes that depend on smalt
# Expected result: List of recipes (if any) that depend on smalt
rg -l 'smalt' recipes/*/meta.yaml
Length of output: 319519
Script:
#!/bin/bash
# Search for smalt dependencies in related meta.yaml files
rg -i "smalt" recipes/shiver/meta.yaml recipes/quatradis/meta.yaml recipes/iva/meta.yaml recipes/biotradis/meta.yaml
Length of output: 372
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
aarch64-smalt
branch
from
956a7ea to
8bb8633
Compare
|
The ARM64 builds fail with: The package needs to be updated to Python 3.x |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.Summary by CodeRabbit
New Features
smaltpackage.linux-aarch64andosx-arm64.smaltsubpackage.Bug Fixes