-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hmftools-bam-tools to 1.3_beta #51142
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/hmftools-bam-tools/meta.yaml (1)
1-1
: Version update looks good, consider adding a note about beta status.The version update to "1.3_beta" is consistent with the PR objective. However, since this is a beta version, it might be helpful to add a comment or note in the recipe to inform users about the pre-release status.
Consider adding a comment like this:
{% set version = "1.3_beta" %} # Note: This is a beta release🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/hmftools-bam-tools/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/hmftools-bam-tools/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (4)
recipes/hmftools-bam-tools/meta.yaml (4)
Line range hint
11-11
: Source URL update is correct.The source URL has been properly updated to reflect the new version. The use of Jinja2 templating (
{{ version }}
) ensures that the URL will always match the specified version, which is a good practice.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
Line range hint
1-35
: Verify if additional updates are needed for the new version.The changes for updating to version 1.3_beta are consistent and properly implemented. However, it's worth verifying if any other updates are needed:
- Do any dependencies need to be updated for this new version?
- Are there any changes in the build process or runtime requirements?
- Has the license or any other metadata changed?
Please double-check these aspects to ensure the recipe is fully up-to-date.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
1-1
: Ignore YAML syntax error for Jinja2 templating.The static analysis tool reported a syntax error for the '%' character, but this is a false positive. The use of
{% ... %}
is correct Jinja2 templating syntax, which is commonly used in Conda recipes. No action is needed to address this warning.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
2-2
: SHA256 checksum updated, verify correctness.The SHA256 checksum has been updated, which is necessary for the new version. However, it's crucial to ensure the checksum is correct.
Please run the following script to verify the SHA256 checksum:
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
Update hmftools-bam-tools recipe to 1.3_beta
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.Summary by CodeRabbit
New Features
hmftools-bam-tools
package to version 1.3_beta.Bug Fixes