Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hmftools-bam-tools to 1.3_beta #51142

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

scwatts
Copy link
Contributor

@scwatts scwatts commented Oct 4, 2024

Update hmftools-bam-tools recipe to 1.3_beta


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Summary by CodeRabbit

  • New Features

    • Updated the hmftools-bam-tools package to version 1.3_beta.
    • Adjusted the source URL to reflect the new version.
  • Bug Fixes

    • Updated SHA256 checksum for improved integrity verification.

Copy link
Contributor

coderabbitai bot commented Oct 4, 2024

📝 Walkthrough

Walkthrough

The pull request updates the meta.yaml file for the hmftools-bam-tools package. Key changes include updating the version from "1.2.1" to "1.3_beta", revising the SHA256 checksum for integrity verification, and modifying the source URL to correspond with the new version. No other structural changes were made to the package configuration or metadata.

Changes

File Change Summary
recipes/hmftools-bam-tools/meta.yaml - Updated version from "1.2.1" to "1.3_beta"
- Changed SHA256 checksum
- Updated source URL to reflect new version

Possibly related PRs

  • update Hsdecipher des #51023: The update to the hsdecipher package's meta.yaml file includes a SHA256 checksum change, similar to the checksum update in the main PR for hmftools-bam-tools.
  • Update quatradis to 1.3.1 #51027: The quatradis package's meta.yaml file also underwent a version update and SHA256 checksum change, paralleling the changes made in the main PR.
  • Update slow5tools to 1.3.0 #51048: The slow5tools package's meta.yaml file features a version increment and SHA256 checksum update, akin to the modifications in the main PR.
  • Update Hsdecipher #51093: The hsdecipher package's version and SHA256 checksum updates are similar to the changes made in the main PR for hmftools-bam-tools.

Suggested labels

autobump, new version


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
recipes/hmftools-bam-tools/meta.yaml (1)

1-1: Version update looks good, consider adding a note about beta status.

The version update to "1.3_beta" is consistent with the PR objective. However, since this is a beta version, it might be helpful to add a comment or note in the recipe to inform users about the pre-release status.

Consider adding a comment like this:

{% set version = "1.3_beta" %}  # Note: This is a beta release
🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e9865fd and a74f13f.

📒 Files selected for processing (1)
  • recipes/hmftools-bam-tools/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/hmftools-bam-tools/meta.yaml

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)

🔇 Additional comments (4)
recipes/hmftools-bam-tools/meta.yaml (4)

Line range hint 11-11: Source URL update is correct.

The source URL has been properly updated to reflect the new version. The use of Jinja2 templating ({{ version }}) ensures that the URL will always match the specified version, which is a good practice.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


Line range hint 1-35: Verify if additional updates are needed for the new version.

The changes for updating to version 1.3_beta are consistent and properly implemented. However, it's worth verifying if any other updates are needed:

  1. Do any dependencies need to be updated for this new version?
  2. Are there any changes in the build process or runtime requirements?
  3. Has the license or any other metadata changed?

Please double-check these aspects to ensure the recipe is fully up-to-date.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


1-1: Ignore YAML syntax error for Jinja2 templating.

The static analysis tool reported a syntax error for the '%' character, but this is a false positive. The use of {% ... %} is correct Jinja2 templating syntax, which is commonly used in Conda recipes. No action is needed to address this warning.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


2-2: SHA256 checksum updated, verify correctness.

The SHA256 checksum has been updated, which is necessary for the new version. However, it's crucial to ensure the checksum is correct.

Please run the following script to verify the SHA256 checksum:

@scwatts
Copy link
Contributor Author

scwatts commented Oct 4, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
noarch hmftools-bam-tools-1.3_beta-hdfd78af_0.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
hmftools-bam-tools 1.3_beta--hdfd78af_0 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/hmftools-bam-tools:1.3_beta--hdfd78af_0.tar.gz | docker load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants