Update nf-core to 3.0.1 #51272
Update nf-core to 3.0.1 #51272
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
recipes/nf-core/meta.yaml (1)
Line range hint
1-85: Consider reviewing dependencies and build specifications.While the version update appears to be minor (3.0.0 to 3.0.1), it's worth considering the following:
Dependencies: Review if any of the package dependencies need to be updated along with this version bump. The current dependencies list remains unchanged, which is likely correct for a minor update, but it's good to confirm.
Build specifications: The 'noarch: python' specification and Python version requirement (>=3.8) remain unchanged, which is appropriate for a minor version update. However, it's good to verify that these specifications are still correct for version 3.0.1.
Build number: The build number is set to 0, which is correct for a new version. No action needed here, but it's good to note.
These aspects look appropriate for a minor version update, but a quick verification could ensure everything is up-to-date.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/nf-core/meta.yaml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
recipes/nf-core/meta.yaml (1)
2-2: Version update looks good.The version has been correctly updated from 3.0.0 to 3.0.1, which aligns with the PR objective.
| {% set version = "3.0.0" %} | ||
| {% set sha256 = "ab67b23840104f7f4125b13519ced9c8021494c03d2eba3f9af6bb3176588846" %} | ||
| {% set version = "3.0.1" %} | ||
| {% set sha256 = "2ae884ac4d4ff200bd21a69a8c44d4b50e13c16a13474ed570e91955b335c2d7" %} |
There was a problem hiding this comment.
💡 Codebase verification
SHA256 checksum is not set correctly.
The sha256 field in recipes/nf-core/meta.yaml is currently set to a placeholder ('{{') instead of the actual checksum value. Please update it with the correct SHA256 checksum for the nf-core 3.0.1 package.
🔗 Analysis chain
SHA256 checksum update looks correct.
The SHA256 checksum has been updated, which is expected for a new package version. However, it's crucial to verify that this checksum corresponds to the correct nf-core 3.0.1 package.
To verify the checksum, you can run the following script:
This script will download the package, calculate its checksum, and compare it with the one in the meta.yaml file.
To address the checksum verification issue, please run the following updated script:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the SHA256 checksum of the nf-core 3.0.1 package
# Download the package
curl -L -o nf_core-3.0.1.tar.gz https://pypi.io/packages/source/n/nf-core/nf_core-3.0.1.tar.gz
# Calculate the SHA256 checksum
calculated_checksum=$(sha256sum nf_core-3.0.1.tar.gz | awk '{print $1}')
# Compare with the checksum in the meta.yaml file
expected_checksum=$(grep 'sha256:' recipes/nf-core/meta.yaml | awk '{print $2}' | tr -d "'")
echo "Calculated checksum: $calculated_checksum"
echo "Expected checksum: $expected_checksum"
if [ "$calculated_checksum" = "$expected_checksum" ]; then
echo "Checksum verification successful!"
else
echo "Checksum verification failed!"
fi
# Clean up
rm nf_core-3.0.1.tar.gz
Length of output: 1131
Script:
#
#!/bin/bash
# Description: Verify the SHA256 checksum of the nf-core 3.0.1 package using shasum
# Download the package
curl -L -o nf_core-3.0.1.tar.gz https://pypi.io/packages/source/n/nf-core/nf_core-3.0.1.tar.gz
# Calculate the SHA256 checksum using shasum
calculated_checksum=$(shasum -a 256 nf_core-3.0.1.tar.gz | awk '{print $1}')
# Extract the expected checksum from the meta.yaml file
expected_checksum=$(grep 'sha256:' recipes/nf-core/meta.yaml | awk '{print $2}' | tr -d "'\"")
echo "Calculated checksum: $calculated_checksum"
echo "Expected checksum: $expected_checksum"
if [ "$calculated_checksum" = "$expected_checksum" ]; then
echo "Checksum verification successful!"
else
echo "Checksum verification failed!"
fi
# Clean up
rm nf_core-3.0.1.tar.gz
Length of output: 1137
Update
nf-core: 3.0.0 → 3.0.1recipes/nf-core(click to view/edit other files)This pull request was automatically generated (see docs).