-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ntlink to 1.3.11 #51348
Update ntlink to 1.3.11 #51348
Conversation
📝 WalkthroughWalkthroughThe pull request introduces an update to the Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/ntlink/meta.yaml (1)
9-9
: SHA256 update is correct, but remove trailing spaces.The SHA256 checksum has been updated correctly for the new version. However, there are trailing spaces at the end of this line that should be removed.
Please apply the following change to remove the trailing spaces:
- sha256: ca92bd4eb4cd6f2f81db54faaeaaf4686236f42db4b6f274f552a52a8460b869 + sha256: ca92bd4eb4cd6f2f81db54faaeaaf4686236f42db4b6f274f552a52a8460b869🧰 Tools
🪛 yamllint
[error] 9-9: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/ntlink/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/ntlink/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
[error] 9-9: trailing spaces
(trailing-spaces)
🔇 Additional comments (3)
recipes/ntlink/meta.yaml (3)
1-1
: Version update looks good.The version has been correctly updated to "1.3.11" as per the PR objectives. This change is appropriate for the package update.
Note: The static analysis tool flagged a syntax error on this line, but this is a false positive. The
{% set version = "1.3.11" %}
syntax is valid Jinja2 template syntax commonly used in Conda recipes.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
12-12
: Build number reset is correct.The build number has been appropriately reset to 0 for the new version. This is the correct practice when updating to a new version of the package.
Line range hint
1-45
: Verify package requirements and test commands for the new version.The version update, SHA256 change, and build number reset have been implemented correctly. However, it's important to ensure that the package requirements and test commands are still valid for the new version.
Please run the following script to check if there have been any significant changes in the package that might require updates to the requirements or test commands:
Review the output to determine if any updates to the requirements or test commands are necessary for version 1.3.11.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
[error] 9-9: trailing spaces
(trailing-spaces)
Update
ntlink
: 1.3.10 → 1.3.11recipes/ntlink
(click to view/edit other files)@bcgsc
This pull request was automatically generated (see docs).