Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Crabs #51394

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Update Crabs #51394

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe65111
first try to update crabs
famosab Oct 15, 2024
e791e92
Add run_exports
martin-g Oct 15, 2024
3adf5b9
clean up recipe
mencian Oct 24, 2024
c785fa3
Merge branch 'master' into update-crabs
mencian Oct 24, 2024
13e7ac7
edit biopython pinning
mencian Oct 24, 2024
b0c830f
remove argparse
mencian Oct 24, 2024
6b838fe
add rich
mencian Oct 24, 2024
6dcce21
add rich-click
mencian Oct 24, 2024
90757f8
add requests
mencian Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions recipes/crabs/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,50 @@
{% set name = "crabs" %}
{% set version = "1.0.3" %}
{% set sha256 = "9ebdf217c0f4069a7678d458b87199c1a2594879c704f0ef91e6049bfc0fae9b" %}

package:
name: crabs
version: "0.1.1"
name: {{ name|lower }}
version: {{ version }}

source:
url: https://github.com/gjeunen/reference_database_creator/files/8028374/crabs_v0.1.1.tar.gz
md5: 6c2e82fb5e191cb750c5d6a41fa24b61
url: https://github.com/gjeunen/reference_database_creator/archive/refs/tags/v{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
number: 0
script: "{{ PYTHON }} -m pip install . -vv"
script: "{{ PYTHON }} -m pip install . --no-deps --no-build-isolation --no-cache-dir -vvv"
noarch: python
martin-g marked this conversation as resolved.
Show resolved Hide resolved
run_exports:
- {{ pin_subpackage(name, max_pin="x") }}
Comment on lines +17 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider tighter version pinning in run_exports.

The current configuration allows major version updates. Consider using x.x for max_pin as suggested in the previous review to prevent potential breaking changes:

  run_exports:
-    - {{ pin_subpackage(name, max_pin="x") }}
+    - {{ pin_subpackage(name, max_pin="x.x") }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run_exports:
- {{ pin_subpackage(name, max_pin="x") }}
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}


requirements:
build:

host:
- python >=3.6.10
- python >=3.6
- pip
- argparse
- biopython =1.78
- tqdm
- numpy
- pandas >=0.23.4
- matplotlib-base
- wget

- setuptools
run:
- python >=3.6.10
- argparse
- biopython =1.78
- python >=3.6
- biopython
- tqdm
- numpy
- pandas >=0.23.4
- matplotlib-base
- wget
- muscle >=3.8.31
- muscle
- cutadapt >=3.4
- vsearch >=2.13.3
- rich
- rich-click
- requests

test:
commands:
- crabs -h

about:
home: https://github.com/gjeunen/reference_database_creator
license: MIT License
summary: Crabs (Creating Reference databases for Amplicon-Based Sequencing) is a program to download and curate reference databases for eDNA metabarcoding analyses

license: MIT
license_family: MIT
license_file: LICENSE
summary: "Crabs (Creating Reference databases for Amplicon-Based Sequencing) is a program to download and curate reference databases for eDNA metabarcoding analyses."
dev_url: https://github.com/gjeunen/reference_database_creator