Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extra architectures. #51503

Closed
wants to merge 1 commit into from
Closed

Add support for extra architectures. #51503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions recipes/diamond/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,6 @@ extra:
identifiers:
- biotools:Diamond
- doi:10.1038/s41592-021-01101-x
additional-platforms:
- osx-arm64
- linux-aarch64
Comment on lines +47 to +49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing build configurations for new platforms

The additional-platforms for 'osx-arm64' and 'linux-aarch64' have been added to meta.yaml, but there are no corresponding architecture-specific build configurations. Please add the necessary build scripts or configurations to support these platforms.

🔗 Analysis chain

LGTM! Verify build processes for new architectures.

The addition of additional-platforms with 'osx-arm64' and 'linux-aarch64' aligns well with the PR objectives to add support for extra architectures. This change enhances the accessibility of the 'diamond' package across different operating systems and hardware platforms.

To ensure these changes are properly integrated, please verify:

  1. The build processes for these new architectures are in place.
  2. The CI pipeline can successfully build and test the package for these platforms.

You can use the following script to check if there are any architecture-specific build scripts or configurations:

If no results are found, you may need to add architecture-specific build scripts or update the existing ones to support these new platforms.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for architecture-specific build configurations

# Test: Search for architecture-specific build scripts or configurations
echo "Searching for architecture-specific build configurations..."
rg -i '(osx-arm64|linux-aarch64|arm64|aarch64)' recipes/diamond/

Length of output: 283

Loading