Update dnmtools to 1.4.4 #51510
Update dnmtools to 1.4.4 #51510
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThis pull request introduces updates to the Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
recipes/dnmtools/build.sh (2)
4-4: LGTM: autoreconf added for configuration regenerationRunning
autoreconf -ifis a good practice to ensure all configuration scripts are up-to-date. This is especially important when updating package versions.Consider adding a comment explaining why this step is necessary, e.g.:
# Regenerate configuration files autoreconf -if
7-7: LGTM: Improved make command with parallel build supportThe updated make command now includes:
${CXXFLAGS}, which allows for flags set by the build system.-j"${CPU_COUNT}"for parallel compilation, which can significantly speed up the build process.These are excellent improvements that enhance build flexibility and performance.
Consider breaking the long line for better readability:
make CXXFLAGS="${CXXFLAGS} -O3 -DNDEBUG -D_LIBCPP_DISABLE_AVAILABILITY" \ -j"${CPU_COUNT}"recipes/dnmtools/meta.yaml (2)
36-38: Test section addition is good, but could be expanded.The addition of a test section with a basic command to run 'dnmtools' is appropriate. However, consider expanding the tests to cover more functionality if possible.
Would you like assistance in generating more comprehensive test commands?
🧰 Tools
🪛 yamllint
[error] 37-37: trailing spaces
(trailing-spaces)
33-33: Minor: Remove trailing spaces.There are trailing spaces on lines 33 and 37. While these don't affect functionality, removing them improves code cleanliness.
Also applies to: 37-37
🧰 Tools
🪛 yamllint
[error] 33-33: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/dnmtools/build.sh (1 hunks)
- recipes/dnmtools/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/dnmtools/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
🔇 Additional comments (9)
recipes/dnmtools/build.sh (3)
3-3: LGTM: Explicit M4 path setSetting the M4 environment variable ensures the correct version of m4 is used during the build process. This is a good practice, especially in cross-compilation environments.
5-5: LGTM: Improved robustness in configure commandAdding quotes around
"${PREFIX}"in the configure command is a good practice. It ensures correct handling of paths that may contain spaces.
1-8: Overall: Excellent improvements to the build processThe changes in this file collectively enhance the build process for dnmtools:
- Explicit setting of the M4 path ensures the correct tool is used.
- Addition of
autoreconfensures up-to-date configuration files.- Quoting of
${PREFIX}improves robustness against paths with spaces.- Updated make command allows for system-specific flags and parallel compilation.
These changes should result in a more reliable and potentially faster build process, which is particularly beneficial for cross-platform compatibility and CI/CD pipelines.
recipes/dnmtools/meta.yaml (6)
1-1: Version update looks good.The package version has been correctly updated to "1.4.4" as per the PR objective.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
8-9: Source section update is correct.The URL and SHA256 checksum have been properly updated to match the new version 1.4.4.
23-23: Build requirement addition is appropriate.The addition of 'libtool' to the build requirements is consistent with the changes in the build process mentioned in the AI summary.
28-29: Host and run requirements update looks good.The addition of 'llvm-openmp' for macOS and 'libgomp' for Linux in both host and run requirements suggests improved OpenMP support across platforms.
Also applies to: 33-34
42-43: About section updates are appropriate and informative.The additions of license family information and dev_url, along with the minor update to the summary text, provide more comprehensive metadata for the package.
Also applies to: 46-46, 48-48
54-56: Extra section update expands platform support.The addition of linux-aarch64 and osx-arm64 as additional platforms is a positive change, expanding support to ARM-based systems.
Update
dnmtools: 1.4.3 → 1.4.4recipes/dnmtools(click to view/edit other files)Home | https://github.com/smithlabcode/dnmtools
Releases |
Recipe Maintainer(s) | @andrewdavidsmith, @guilhermesena1
Author |
@smithlabcodeThis pull request was automatically generated (see docs).