-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create FC-Virus #51579
base: master
Are you sure you want to change the base?
Create FC-Virus #51579
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,31 @@ | ||||||||||||||||||||||||||||||||||||
package: | ||||||||||||||||||||||||||||||||||||
name: FC-Virus | ||||||||||||||||||||||||||||||||||||
version: "1.0.0" | ||||||||||||||||||||||||||||||||||||
noarch: generic | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
source: | ||||||||||||||||||||||||||||||||||||
url: https://github.com/qdu-bioinfo/FC-Virus/archive/refs/heads/main.tar.gz | ||||||||||||||||||||||||||||||||||||
git_tag: main | ||||||||||||||||||||||||||||||||||||
sha256: a5c91ea315dc7b64b75986128d97c08522aae332cb640fd2c115cc379b4adc51 | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
build: | ||||||||||||||||||||||||||||||||||||
number: 0 | ||||||||||||||||||||||||||||||||||||
skip: true | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
Comment on lines
+11
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove skip: true and revise package architecture Two issues with the build configuration:
Apply these changes: - noarch: generic
build:
number: 0
- skip: true
|
||||||||||||||||||||||||||||||||||||
requirements: | ||||||||||||||||||||||||||||||||||||
build: | ||||||||||||||||||||||||||||||||||||
- gcc | ||||||||||||||||||||||||||||||||||||
- gxx_linux-64 | ||||||||||||||||||||||||||||||||||||
- make | ||||||||||||||||||||||||||||||||||||
- boost | ||||||||||||||||||||||||||||||||||||
run: | ||||||||||||||||||||||||||||||||||||
- boost | ||||||||||||||||||||||||||||||||||||
Comment on lines
+15
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reorganize dependencies following conda-forge best practices The dependencies section needs several improvements:
Apply this diff: requirements:
build:
- - gcc
- - gxx_linux-64
- make
+ - {{ compiler('c') }}
+ - {{ compiler('cxx') }}
+ host:
- boost >=1.70.0
run:
- - boost
+ - boost >=1.70.0 📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
about: | ||||||||||||||||||||||||||||||||||||
home: https://github.com/qdu-bioinfo/FC-Virus | ||||||||||||||||||||||||||||||||||||
license: MIT | ||||||||||||||||||||||||||||||||||||
summary: "Accurate Assembly of Full-length Consensus for Viral Quasispecies" | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
test: | ||||||||||||||||||||||||||||||||||||
commands: | ||||||||||||||||||||||||||||||||||||
- ./bin/FC-Virus --help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a specific release tag instead of main branch
Using the main branch as the source is not recommended for reproducibility as it can change over time. Since this is version 1.0.0, you should:
Apply this diff:
📝 Committable suggestion