Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snakemake to 8.24.1 #51586

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update snakemake to 8.24.1 #51586

merged 2 commits into from
Oct 23, 2024

Conversation

BiocondaBot
Copy link
Collaborator

Update snakemake: 8.24.08.24.1

install with bioconda Conda

Info Link or Description
Recipe recipes/snakemake (click to view/edit other files)
Summary A popular workflow management system aiming at full in-silico reproducibility.
Home https://snakemake.github.io
Releases https://pypi.org/pypi/snakemake/json
Recipe Maintainer(s) @johanneskoester, @corneliusroemer

This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Oct 23, 2024
Copy link
Contributor

coderabbitai bot commented Oct 23, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request involves an update to the meta.yaml file for the Snakemake package. The primary changes include updating the version number from "8.24.0" to "8.24.1" and modifying the SHA256 checksum of the source tarball to reflect the new version. The checksum has been changed from 4445f33e4e23ae9025bbc5aef46b868d8b615ef463544659674db8aabf40bcd4 to 0559831260cdfb216d9c20f7e8465d841333935eac15f62787cec6d266efbf01. Additionally, the requirements section has been updated to ensure that the snakemake-minimal dependency corresponds with the new version. The version constraints for pulp, requests, and snakemake-interface-report-plugins have been adjusted accordingly. The python version constraint remains unchanged but includes a comment regarding potential breaking changes in minor version bumps. No other alterations have been made to the structure, dependencies, or additional metadata within the meta.yaml file.

Possibly related PRs

  • Update snakemake to 8.24.0 #51530: This PR updates the version of the Snakemake package from 8.23.2 to 8.24.0, which is directly related to the main PR that updates the version from 8.24.0 to 8.24.1.

Suggested reviewers

  • martin-g

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 462b0b4 and 251aaf4.

📒 Files selected for processing (1)
  • recipes/snakemake/meta.yaml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/snakemake/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cc53905 and 462b0b4.

📒 Files selected for processing (1)
  • recipes/snakemake/meta.yaml (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
recipes/snakemake/meta.yaml (2)

4-4: LGTM: Version update is consistent.

The version bump from 8.24.0 to 8.24.1 is correctly reflected in the package metadata.


12-12: Verify SHA256 checksum against PyPI release.

Let's verify that the SHA256 checksum matches the official release on PyPI.

✅ Verification successful

Let me try a different approach to verify the checksum.

This script will:

  1. Show us the full meta.yaml to confirm the version and checksum
  2. Query PyPI's JSON API to get the official SHA256 for the source distribution of version 8.24.1

SHA256 checksum verified successfully

The SHA256 checksum in the recipe (0559831260cdfb216d9c20f7e8465d841333935eac15f62787cec6d266efbf01) matches exactly with the official checksum from PyPI for snakemake version 8.24.1.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the SHA256 checksum matches the PyPI release
# Download the package and compute its checksum
VERSION="8.24.1"
PACKAGE="snakemake"
EXPECTED_SHA="0559831260cdfb216d9c20f7e8465d841333935eac15f62787cec6d266efbf01"

echo "Downloading $PACKAGE-$VERSION from PyPI..."
curl -sL "https://pypi.io/packages/source/s/$PACKAGE/$PACKAGE-$VERSION.tar.gz" | sha256sum
echo "Expected SHA256: $EXPECTED_SHA"

Length of output: 2650


Script:

#!/bin/bash
# Let's verify the version and checksum from the recipe
cat recipes/snakemake/meta.yaml

# Then let's try to fetch the package info from PyPI
curl -s "https://pypi.org/pypi/snakemake/json" | jq -r '.releases["8.24.1"][] | select(.packagetype=="sdist") | .digests.sha256'

Length of output: 4936

@johanneskoester johanneskoester enabled auto-merge (squash) October 23, 2024 10:34
@johanneskoester johanneskoester merged commit 9a1b7be into master Oct 23, 2024
6 of 7 checks passed
@johanneskoester johanneskoester deleted the bump/snakemake branch October 23, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump Automatic Version Update new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants