Update 0.0.1a1 #51590
Update 0.0.1a1 #51590
Conversation
📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/quota_anchor/meta.yaml (1)
Line range hint
18-20: Review run_exports pinning strategy.The current run_exports configuration pins to x.x (major.minor), which might be too strict for an alpha release (0.0.1a1). Consider if this pinning strategy is appropriate for pre-release versions.
For pre-release versions, you might want to be more lenient with pinning to allow for rapid development changes. Consider using
x.x.xinstead.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/quota_anchor/meta.yaml (3 hunks)
🧰 Additional context used
🔇 Additional comments (3)
recipes/quota_anchor/meta.yaml (3)
42-42: Verify alive-progress version constraints.The alive-progress package has been added as a runtime dependency without version constraints. Consider if specific version constraints are needed to ensure compatibility.
Let's check the upstream requirements:
#!/bin/bash # Check for version constraints in setup.py or requirements.txt rg -A 5 "alive-progress" | rg "requirements\.(txt|in)$|setup\.py$"
24-24: Consider if setuptools is really needed as a host requirement.Since this is a Python package using pip for installation, setuptools might be automatically pulled in by pip. However, if the package's setup.py explicitly imports setuptools or uses setup.py features that require it, then this addition is correct.
Let's check if setuptools is explicitly required:
#!/bin/bash # Check setup.py for setuptools usage rg -l "setuptools" | rg "setup\.py$"
2-3: LGTM: Version and checksum update look correct.The version bump from 0.0.1a0 to 0.0.1a1 and its corresponding SHA256 checksum update are properly synchronized.
Let's verify the checksum matches the upstream release:
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.