Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crux-toolkit to 4.2 #51625

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+39 −36
Open

Update crux-toolkit to 4.2 #51625

Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3925986
Updated to version 4.2
CharlesEGrant Oct 24, 2024
70e467c
Merge branch 'bioconda:master' into crux-toolkit-4.2
CharlesEGrant Oct 24, 2024
6c7ea37
Reset build number to 0
CharlesEGrant Oct 24, 2024
e886590
Reset build number to 0
CharlesEGrant Oct 24, 2024
d13e6b8
Merge branch 'bioconda:master' into crux-toolkit-4.2
CharlesEGrant Oct 25, 2024
87484a4
Merge branch 'crux-toolkit-4.2' of github.com:CharlesEGrant/bioconda-…
CharlesEGrant Oct 25, 2024
0cae8c5
Fixed run_exports_ lint complaint
CharlesEGrant Oct 25, 2024
1f51415
Fixed run_exports_ lint complaint
CharlesEGrant Oct 25, 2024
20859a7
Fixed run_exports_ lint complaint
CharlesEGrant Oct 25, 2024
f2046e1
Fixed run_exports_ lint complaint
CharlesEGrant Oct 25, 2024
1f10b48
Trying to specify c/c++ runtimes
CharlesEGrant Oct 25, 2024
5d4a701
Trying to specify c/c++ runtimes
CharlesEGrant Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 39 additions & 36 deletions recipes/crux-toolkit/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,39 @@
{% set version = "4.1" %}

package:
name: crux-toolkit
version: {{ version }}

source:
- url: https://noble.gs.washington.edu/crux-downloads/crux-{{ version }}/crux-{{ version }}.Linux.x86_64.zip # [linux]
sha256: c056f1e632dfaf8d0c6f6769fbdaf78eef6fd586a6b732d88ad0c01fe2da077d # [linux]
- url: https://noble.gs.washington.edu/crux-downloads/crux-{{ version }}/crux-{{ version }}.Darwin.x86_64.zip # [osx]
sha256: 9f7b060e67ec250e4c2a10b783eb1777497ec0d1151e5bc9630f67f411b595ac # [osx]

build:
number: 2
script: "mkdir -p $PREFIX/bin; chmod a+x bin/*; cp bin/* $PREFIX/bin"

requirements:
build:
# both needed as run-time dependencies
- {{ compiler('c') }}
- {{ compiler('cxx') }}

test:
commands:
- crux version 2> /dev/null | grep -q 'Crux version'

about:
home: http://crux.ms
summary: A cross-platform suite of analysis tools for interpreting protein mass spectrometry data
license: Apache-2.0
license_family: Apache
dev_url: https://github.com/crux-toolkit/crux-toolkit

extra:
skip-lints:
- should_not_be_noarch_source
{% set version = "4.2" %}

package:
name: crux-toolkit
version: {{ version }}

source:
- url: https://noble.gs.washington.edu/crux-downloads/crux-{{ version }}/crux-{{ version }}.Linux.x86_64.zip # [linux]
sha256: b5c1a02416f0220beb6106e12a7b330932dec396291ae364af8f2153a1e1655d # [linux]
- url: https://noble.gs.washington.edu/crux-downloads/crux-{{ version }}/crux-{{ version }}.Darwin.x86_64.zip # [osx]
sha256: 5f1fb9124391cec30608740fdce3aea7fcb3f19330531ea90f6ecf81b8583d00 # [osx]

build:
number: 0
script: "mkdir -p $PREFIX/bin; chmod a+x bin/*; cp bin/* $PREFIX/bin"

requirements:
run:
- {{ compiler('c') }}
- {{ compiler('cxx') }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix requirements section: Move compilers to build requirements.

The compiler requirements are incorrectly placed in the run section. Compilers are build-time dependencies and should be in the build section.

Apply this fix:

 requirements:
-  run:
+  build:
     - {{ compiler('c') }}
     - {{ compiler('cxx') }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
requirements:
run:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
requirements:
build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}

test:
commands:
- crux version 2> /dev/null | grep -q 'Crux version'

about:
home: http://crux.ms
summary: A cross-platform suite of analysis tools for interpreting protein mass spectrometry data
license: Apache-2.0
license_family: Apache
dev_url: https://github.com/crux-toolkit/crux-toolkit

extra:
recipe-maintainers:
- CharlesEGrant
- wsnoble
- acquayefrank
skip-lints:
- should_not_be_noarch_source
Loading