-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update biobb_amber to 5.0.2 #51653
Update biobb_amber to 5.0.2 #51653
Conversation
📝 WalkthroughWalkthroughThe pull request involves an update to the Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/biobb_amber/meta.yaml (2)
Line range hint
44-48
: Documentation links need updating.There's a syntax error in the description field's documentation link. The extra parenthesis and bracket should be removed.
- description: "Biobb_amber is a BioBB category for AMBER MD package. Biobb (BioExcel building blocks) packages are Python building blocks that create new layer of compatibility and interoperability over popular bioinformatics tools. The latest documentation of this package can be found in our readthedocs site: http://biobb_amber.readthedocs.io/en/latest/)](http://biobb_amber.readthedocs.io/en/latest/" + description: "Biobb_amber is a BioBB category for AMBER MD package. Biobb (BioExcel building blocks) packages are Python building blocks that create new layer of compatibility and interoperability over popular bioinformatics tools. The latest documentation of this package can be found in our readthedocs site: http://biobb_amber.readthedocs.io/en/latest/"🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
Line range hint
42-43
: Missing license file specification.The
license_file
field is empty but the package is Apache licensed. This should be specified.license: Apache Software License license_family: APACHE - license_file: '' + license_file: LICENSE🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/biobb_amber/meta.yaml (1 hunks)
🔇 Additional comments (3)
recipes/biobb_amber/meta.yaml (3)
Line range hint
22-29
: Verify dependency compatibility.The package maintains its dependencies:
- biobb_common ==5.0.0
- ambertools ==22.5.0
- Python >=3.8,<3.11
Let's verify if these versions are compatible with the new version.
#!/bin/bash # Description: Check if dependencies exist in conda-forge/bioconda # Expected: All dependencies should be available echo "Checking conda-forge/bioconda for dependencies..." conda search biobb_common==5.0.0 -c conda-forge -c bioconda || echo "biobb_common 5.0.0 not found" conda search ambertools==22.5.0 -c conda-forge -c bioconda || echo "ambertools 22.5.0 not found"🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
2-2
: Verify version bump authenticity.Let's verify that this version exists in the upstream repository and PyPI.
✅ Verification successful
Let me gather more information about the package release by checking the repository tags and commits.
Version 5.0.2 is verified and available in both PyPI and GitHub tags
The version bump to 5.0.2 is legitimate as:
- Version 5.0.2 exists in PyPI releases
- Git tag
v5.0.2
is present in the upstream repository (bioexcel/biobb_amber)🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version exists in PyPI and matches upstream # Expected: Version 5.0.2 should exist in PyPI and match the GitHub release # Check PyPI version echo "Checking PyPI version..." curl -s https://pypi.org/pypi/biobb_amber/json | jq -r '.releases | keys[]' | grep "5.0.2" || echo "Version not found in PyPI" # Check GitHub releases echo "Checking GitHub releases..." gh release list --repo bioexcel/biobb_amber | grep "5.0.2" || echo "Version not found in GitHub releases"Length of output: 362
Script:
#!/bin/bash # Check git tags and commits for version 5.0.2 echo "Checking git tags..." git ls-remote --tags https://github.com/bioexcel/biobb_amber.git | grep "5.0.2" echo -e "\nChecking recent commits..." git ls-remote --heads https://github.com/bioexcel/biobb_amber.git main | cut -f1 | xargs -I{} curl -s "https://api.github.com/repos/bioexcel/biobb_amber/commits/{}" | jq -r '.commit.message' | head -n 5Length of output: 523
10-10
: Verify SHA256 checksum authenticity.Let's verify the SHA256 matches the PyPI source distribution.
Closing in favor of #51649. |
Update
biobb_amber
: 5.0.0 → 5.0.2recipes/biobb_amber
(click to view/edit other files)This pull request was automatically generated (see docs).