Add ntStat #51884
Add ntStat #51884
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThis pull request introduces two new files: Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ntstat/meta.yaml
Outdated
| sha256: 262dc58ab6f781a6816a5d4fc129659c7fa2c3364871320eafb45bfa822fab6a | ||
|
|
||
| build: | ||
| noarch: generic |
There was a problem hiding this comment.
| noarch: generic |
This recipe builds arch specific binaries, so it is not noarch
ntstat/meta.yaml
Outdated
|
|
||
| about: | ||
| home: https://github.com/bcgsc/ntStat | ||
| license: GPL-3.0 |
There was a problem hiding this comment.
| license: GPL-3.0 | |
| license: GPL-3.0-or-later |
SPDX id
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
ntstat/meta.yaml (2)
16-37: Consider adding version constraints for dependencies.While most dependencies don't have version constraints,
btllibis pinned to>=1.7.2. Consider if other dependencies (especially Python packages like matplotlib, numpy, scipy) need minimum version requirements to ensure compatibility.
39-42: Consider adding more comprehensive tests.Current tests only verify basic command availability. Consider adding:
- Tests for other subcommands besides 'count'
- Tests that verify Python package imports if this provides a Python API
- Tests with minimal example inputs if possible
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
ntstat/meta.yaml(1 hunks)
🧰 Additional context used
🪛 yamllint
ntstat/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (4)
ntstat/meta.yaml (4)
1-6: LGTM!
The package metadata section follows conda recipe best practices with proper version templating.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
44-48: LGTM!
The about section is complete with all required fields and follows the SPDX license identifier format.
11-14: Verify the necessity of run_exports.
The run_exports section suggests this package provides a library that other packages might depend on. However, looking at the package description and test commands, this appears to be primarily a command-line tool. Please verify if run_exports is necessary.
#!/bin/bash
# Description: Check if package is used as a dependency by other packages
# Search for ntstat as a requirement in other recipes
echo "Checking if ntstat is used as a dependency in other recipes..."
rg -l "ntstat" --type yaml7-9: Verify source checksum integrity.
Let's verify the provided SHA256 checksum matches the source tarball.
|
@bgruening this merge should probably be reverted. The ntstat folder is not inside the recipe folder. |
|
Arg, we should have a lint for this. |
|
@xfengnefx can you please submit this again, we needed to revert this PR in #51892 |
|
Apologies for the mistake. Submitted #51897. |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.