Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux-aarch64 and/or osx-arm64 to various perl-* packages 1 of 2 #51910

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add linux-aarch64 and/or osx-arm64 to various perl-* packages 1 of 2 #51910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f84507d
Add linux-aarch64 and/or osx-arm64 to packages.
dslarm Nov 4, 2024
01de73f
Add perl-crypt-openssl-random.
dslarm Nov 4, 2024
a83dc29
mark skip osx64 build due to build fail; retain osx-arm64
dslarm Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions recipes/perl-bloom-faster/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
{% set name = "perl-bloom-faster" %}
{% set version = "1.7" %}
{% set sha256 = "02cfde4f6aca6f7453edb93ba70d36d08081f5ebad8b023188da6379ff1d4a75" %}

package:
name: perl-bloom-faster
name: {{ name }}
version: {{ version }}

source:
url: http://cpan.metacpan.org/authors/id/P/PA/PALVARO/Bloom-Faster-{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
number: 6
run_exports:
- {{ pin_subpackage(name, max_pin="x") }}
number: 7

requirements:
build:
Expand All @@ -30,3 +33,8 @@ about:
home: http://metacpan.org/pod/Bloom-Faster
license: unknown
summary: 'Perl extension for the c library libbloom.'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
9 changes: 8 additions & 1 deletion recipes/perl-class-methodmaker/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ source:


build:
number: 4
run_exports:
- {{ pin_subpackage(name, max_pin="x") }}
number: 5

requirements:
build:
Expand Down Expand Up @@ -43,3 +45,8 @@ about:
home: http://search.cpan.org/~schwigon/Class-MethodMaker-2.24/
license: perl_5
summary: 'Create generic methods for OO Perl'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
11 changes: 9 additions & 2 deletions recipes/perl-crypt-openssl-random/0.11/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ package:
version: {{ version }}

source:
url: https://cpan.metacpan.org/authors/id/R/RU/RURBAN/Crypt-OpenSSL-Random-0.11.tar.gz
url: https://cpan.metacpan.org/authors/id/R/RU/RURBAN/Crypt-OpenSSL-Random-{{ version }}.tar.gz
sha256: {{ sha256 }}

# If this is a new build for the same version, increment the build
# number. If you do not include this key, it defaults to 0.
build:
number: 5
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 6

requirements:
build:
Expand Down Expand Up @@ -45,6 +47,11 @@ about:
license: perl_5
summary: 'OpenSSL/LibreSSL pseudo-random number generator access'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64

# See
# http://docs.continuum.io/conda/build.html for
# more information about meta.yaml
7 changes: 6 additions & 1 deletion recipes/perl-crypt-openssl-rsa/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ source:
# If this is a new build for the same version, increment the build
# number. If you do not include this key, it defaults to 0.
build:
number: 2
number: 3
run_exports:
weak:
- {{ name }} ={{ version }}
Expand Down Expand Up @@ -47,3 +47,8 @@ about:
# See
# https://docs.conda.io/projects/conda-build for
# more information about meta.yaml

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
9 changes: 8 additions & 1 deletion recipes/perl-file-copy-recursive/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ source:
sha256: {{ sha256 }}

build:
number: 3
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 4

requirements:
build:
Expand All @@ -37,3 +39,8 @@ about:
home: https://metacpan.org/pod/File::Copy::Recursive
license: Perl
summary: 'Perl extension for recursively copying files and directories'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
12 changes: 10 additions & 2 deletions recipes/perl-filesys-df/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
{% set name = "perl-filesys-df" %}
{% set version = "0.92" %}
{% set sha256 = "fe89cbb427e0e05f1cd97c2dd6d3866ac6b21bc7a85734ede159bdc35479552a" %}

package:
name: "perl-filesys-df"
name: {{ name }}
version: {{ version }}

source:
url: https://cpan.metacpan.org/authors/id/I/IG/IGUTHRIE/Filesys-Df-{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
number: 7
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 8

requirements:
build:
Expand All @@ -29,3 +32,8 @@ about:
home: http://metacpan.org/pod/Filesys-Df
license: unknown
summary: 'Perl extension for filesystem disk space information.'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
18 changes: 14 additions & 4 deletions recipes/perl-heap-simple-xs/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
{% set name = "perl-heap-simple-xs" %}
{% set version = "0.10" %}

package:
name: perl-heap-simple-xs
version: "0.10"
name: {{ name }}
version: {{ version }}

source:
url: http://cpan.metacpan.org/authors/id/T/TH/THOSPEL/Heap-Simple-XS-0.10.tar.gz
url: http://cpan.metacpan.org/authors/id/T/TH/THOSPEL/Heap-Simple-XS-{{ version }}.tar.gz
md5: 0611ac7984f6ddc3aaa60c75d2257803

build:
number: 6
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 7

requirements:
build:
Expand All @@ -28,3 +33,8 @@ about:
home: http://metacpan.org/pod/Heap::Simple::XS
license: unknown
summary: 'An XS implementation of the Heap::Simple interface'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
9 changes: 8 additions & 1 deletion recipes/perl-ipc-sharelite/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ source:
sha256: {{ sha256 }}

build:
number: 5
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 6

requirements:
build:
Expand All @@ -33,3 +35,8 @@ about:
home: http://metacpan.org/pod/IPC::ShareLite
license: perl_5
summary: 'Lightweight interface to shared memory'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
9 changes: 8 additions & 1 deletion recipes/perl-json-parse/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ source:
sha256: {{ sha256 }}

build:
number: 3
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 4

requirements:
build:
Expand All @@ -33,3 +35,8 @@ about:
home: http://metacpan.org/pod/JSON::Parse
license: perl_5
summary: 'Read JSON into a Perl variable'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
18 changes: 14 additions & 4 deletions recipes/perl-math-cdf/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
{% set name = "perl-math-cdf" %}
{% set version = "0.1" %}

package:
name: perl-math-cdf
version: "0.1"
name: {{ name }}
version: {{ version }}

source:
url: http://cpan.metacpan.org/authors/id/C/CA/CALLAHAN/Math-CDF-0.1.tar.gz
url: http://cpan.metacpan.org/authors/id/C/CA/CALLAHAN/Math-CDF-{{ version }}.tar.gz
md5: 7866c7b6b9d27f0ce4b7637334478ab7

build:
number: 9
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 10

requirements:
build:
Expand All @@ -27,3 +32,8 @@ about:
home: http://metacpan.org/pod/Math-CDF
license: Public Domain
summary: 'Generate probabilities and quantiles from several statistical probability functions'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
20 changes: 16 additions & 4 deletions recipes/perl-math-random/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
{% set name = "perl-math-random" %}
{% set version = "0.72" %}

package:
name: perl-math-random
version: "0.72"
name: {{ name }}
version: {{ version }}

source:
url: https://cpan.metacpan.org/authors/id/G/GR/GROMMEL/Math-Random-0.72.tar.gz
url: https://cpan.metacpan.org/authors/id/G/GR/GROMMEL/Math-Random-{{ version }}.tar.gz
md5: b0b961e2ae06920801a9c9843c48d0bc

build:
number: 6
run_exports:
- {{ pin_subpackage(name, max_pin="x.x") }}
number: 7
# skip osx on x86 - builds fail in CI
skip: True # [osx]
Comment on lines +13 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Update OSX skip configuration to be architecture-specific

The review comment is correct. There is a clear inconsistency in the package configuration:

  1. The comment indicates builds should only be skipped for x86 OSX: # skip osx on x86 - builds fail in CI
  2. The skip directive skip: True # [osx] blocks all OSX builds
  3. The package explicitly lists osx-arm64 as an additional platform, which conflicts with the skip directive

The skip directive should be updated to:

skip: True  # [osx and x86_64]

This will:

  • Only skip x86_64 builds on OSX as intended
  • Allow osx-arm64 builds to proceed
  • Match the documented intention in the comment
  • Be consistent with the additional-platforms configuration
🔗 Analysis chain

Verify OSX build skip configuration

The skip directive skip: True # [osx] skips all OSX builds, but:

  1. The comment suggests it should only skip x86 builds
  2. This conflicts with the addition of osx-arm64 platform support

Consider updating the skip directive to specifically target x86:

- skip: True # [osx]
+ skip: True  # [osx and x86_64]
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify if other perl packages have similar OSX skip patterns
rg -l "skip.*osx" recipes/perl-*/meta.yaml

Length of output: 15891

Script:

#!/bin/bash
# Let's try a different approach to find OSX skip patterns
rg -l "skip.*\[osx" recipes/perl-*/meta.yaml

Length of output: 15970

Script:

#!/bin/bash
# Also check the specific file content
cat recipes/perl-math-random/meta.yaml

Length of output: 775

Script:

#!/bin/bash
# Check if there are any osx-arm64 related entries
rg "osx-arm64" recipes/perl-math-random/meta.yaml

Length of output: 65


requirements:
build:
Expand All @@ -29,3 +36,8 @@ about:
home: http://metacpan.org/pod/Math-Random
license: unknown
summary: 'Random Number Generators'

extra:
additional-platforms:
- linux-aarch64
- osx-arm64