Add nested recipe check to get_recipes #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that conda-build 3 is always using the pinnings defined in https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/conda_build_config.yaml By contributing to this list, we can maintain compatibility with conda-forge.
…of the variant matrix and both linux and osx.
* build: rename --prelint to --lint, add --lint-only/--lint-exclude args * requirements: update to conda-build 3.10.9 * build: remove default value for --lint-exclude * requirements: require python >=3.6 * meta.get_section might return None (conda-build 3.10.9 compat) * silence most flake8 nagging * bioconductor: fix missing newline at EOF for post-link.sh * fix typo * use meta.get_value preferably * make flake8 shut up already * meta.get_value only works for path with depth 2 * lint: fix should_not_be_noarch for conda_build >3.10.3 * lint._has_compilers: also check for old compiler packages * lint._get_deps: fix sections being unset on default * docs: use only one job for debugging
|
@mikecormier could you merge in the latest version of cb3-migration branch? |
Currently get_recipes only support recipes nested up to two deep from the recipe_folder provided. Our application of get_recipes, and potential future uses from others, has recipes nested deeper. This purposed implementation will provide the ability to locate all recipes, no matter how deep, within the user provided recipe_folder.
get_recipes was changed to allow for different levels of recipe nesting. test_depthcheck_get_recipe() will test get_recipes ability to find different levels of nested recipes.
|
@johanneskoester I have merged the latest updates in the cb3-migration into my branch and all test are passing. This PR is ready to be merge. |
johanneskoester
requested changes
Jul 19, 2018
bioconda_utils/utils.py
Outdated
| glob.glob(os.path.join(path, "meta.yaml"))) | ||
| yield from map(os.path.dirname, | ||
| glob.glob(os.path.join(path, "*", "meta.yaml"))) | ||
| for newDir in [x for x in glob.glob(path)]: |
There was a problem hiding this comment.
Please use snake_case for variable names.
There was a problem hiding this comment.
This [x for x in glob.glob(path)] can simply be written as glob.glob(path).
test/test_utils.py
Outdated
| @@ -976,3 +976,98 @@ def test_compiler(): | |||
| for i in utils.built_package_paths(v): | |||
| assert os.path.exists(i) | |||
| ensure_missing(i) | |||
|
|
|||
|
|
|||
| def test_depthcheck_get_recipe(): | |||
There was a problem hiding this comment.
Rather name this test_nested_recipes?
|
cb-3migration is merged into master now. Please switch to master as merge target. |
|
@johanneskoester, |
johanneskoester
approved these changes
Jul 20, 2018
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently get_recipes only support recipes nested up to two deep from the recipe_folder provided. Our application of get_recipes, and potential future uses from others, has recipes nested deeper. This purposed implementation will provide the ability to locate all recipes, no matter how deep, within the user provided recipe_folder.