update-pinnings fixes #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g., "--skip-variants python r_base" should skip recipes that build different variants for python or r-base.
With bypass_env_check we get invalid build string like in "r-dimsum=1.1.3=r>=36_0". conda-build special-cases python/r-base/... deps but with bypass_env_check it cannot resolve the actual versions. In most cases the recipe then needs manual editing anyway because it should use build/skip rather than constrain versions in requirements.
mbargull
commented
Jul 2, 2020
| @@ -541,6 +541,9 @@ def dag(recipe_folder, config, packages="*", format='gml', hide_singletons=False | |||
| help="""Bump package build numbers even if the only applicable pinning | |||
| change is the python version. This is generally required unless you plan | |||
| on building everything.""") | |||
| @arg('--skip-variants', | |||
There was a problem hiding this comment.
I added this as a convenience things so we can update pinnings for Python/R packages separately.
There was a problem hiding this comment.
However, those skips happen after the dependency graph is created, ergo packages that are dependencies of others may not be bumped.
mbargull
commented
Jul 2, 2020
|
|
||
| State = update_pinnings.State | ||
|
|
||
| for status, recip in zip(utils.parallel_iter(needs_bump, dag, "Processing..."), dag): | ||
| for status, recip in utils.parallel_iter(needs_bump, dag, "Processing..."): |
There was a problem hiding this comment.
The order of utils.parallel_iter(...) and iter(dag) is different, apparently, which means we got "random" misassigned build bumps.
|
I'm going ahead with the merge and will tag yet another release so we get the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for
update-pinnings.IMPORTANT: The change from https://github.com/bioconda/bioconda-utils/pull/662/files#diff-2aed786d397cbb062fb58d1ff86a6950R26 caused different build strings for
r-base-dependent packages because it triggered the logic from conda/conda-build#3895. I hadn't thought of that before unfortunately.Thankfully the last Bioconductor
bulkwork happened before that change. That means it should not affect terribly many recipes.