-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support exporting all barplot legends, including color gradient and length legends; export collapsed clade shapes and barplots #392
Commits on Sep 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 46cd6a3 - Browse repository at this point
Copy the full SHA 46cd6a3View commit details -
BUG: Fix legend SVG title centering; <g> => <svg>
Also added a newline after </style>
Configuration menu - View commit details
-
Copy full SHA for 3d61289 - Browse repository at this point
Copy the full SHA 3d61289View commit details -
BUG: Improve legend SVG for SVG importers
-Use "long form" font specification for the style SVG (fixes problems with GIMP and Inkscape) -Put the style code higher up in the output legend SVG -- has the effect of applying the rect stroke to the topmost legend rect, which was a problem in Inkscape but not in chromium (:thonk:) -Add note about GIMP choking on dominant-baseline (tldr not worth worrying abt now i think)
Configuration menu - View commit details
-
Copy full SHA for 55a2ed1 - Browse repository at this point
Copy the full SHA 55a2ed1View commit details -
STY: reorder/split up text and .title svg styles
(the text styles are now across multiple lines)
Configuration menu - View commit details
-
Copy full SHA for 52f483e - Browse repository at this point
Copy the full SHA 52f483eView commit details
Commits on Sep 24, 2020
-
MNT: hang on to continuous props in Legend for SVG
similar to what we do for categorical export
Configuration menu - View commit details
-
Copy full SHA for 77c555a - Browse repository at this point
Copy the full SHA 77c555aView commit details -
ENH: add newlines to within gradient svgs
make life less painful (tm)
Configuration menu - View commit details
-
Copy full SHA for e5a3e54 - Browse repository at this point
Copy the full SHA e5a3e54View commit details -
Configuration menu - View commit details
-
Copy full SHA for d571dcd - Browse repository at this point
Copy the full SHA d571dcdView commit details -
MNT: Refactor colorer/legend handling of gradients
Now, things are split up into a "Solo" and "HTML" SVG -- the gradient shown on the page is a combo of these, and the one we export is just the Solo one. This makes scaling it properly for the export SO MUCH EASIER AHH All we gotta do now is just add in value text and update rowsUsed / maxLineWidth. think that should be good? oh also this is gonna explode the tests ofc. that is a job for TOMORROW MARCUS (tm)
Configuration menu - View commit details
-
Copy full SHA for fca7bae - Browse repository at this point
Copy the full SHA fca7baeView commit details -
ENH: Finish? gradient legend SVG exporting!
IT WORKS SO WELL AOGIHDSOIGHJ something worth noting: there seems to be some unaccounted-for horizontal padding on the right side in the cat legend export. i matched it in the continuous legend export b/c it looks nice but worth looking into...?
Configuration menu - View commit details
-
Copy full SHA for 79d9602 - Browse repository at this point
Copy the full SHA 79d9602View commit details -
MNT: add explicit padding to right side of cat SVG
it looks like things are the opposite from how i thought -- looks like the perceived extra space was just due to the boldfont used in estimating the texts (when you make the text bold it's almost snug with the border on the right side). may as well add the same padding as for the continuous legends so things look consistent ish. Still, this leaves it kinda unclear as to why continuous legends were so comparatively snug with the border until i added padding ... maybe boldface numbers are just not that bigger? idk UPDATE: yeah i checked it and bold numbers are basically the same size but bold letters are much larger. mystery solved 💯
Configuration menu - View commit details
-
Copy full SHA for 766158e - Browse repository at this point
Copy the full SHA 766158eView commit details -
ENH: initial support for exporting length legends
looks not great (gotta align max and min headers like in table) but good enough tm
Configuration menu - View commit details
-
Copy full SHA for 6c04c35 - Browse repository at this point
Copy the full SHA 6c04c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7f54c5 - Browse repository at this point
Copy the full SHA c7f54c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49828bb - Browse repository at this point
Copy the full SHA 49828bbView commit details
Commits on Sep 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f6ceff3 - Browse repository at this point
Copy the full SHA f6ceff3View commit details
Commits on Oct 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4789630 - Browse repository at this point
Copy the full SHA 4789630View commit details -
ENH: export collapsed clade shapes! biocore#303
Actually not that bad. wack.
Configuration menu - View commit details
-
Copy full SHA for 93531a8 - Browse repository at this point
Copy the full SHA 93531a8View commit details -
ENH: draw full rectangle for unrooted collapsing
removes line in the middle
Configuration menu - View commit details
-
Copy full SHA for 1e0f034 - Browse repository at this point
Copy the full SHA 1e0f034View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebd38a6 - Browse repository at this point
Copy the full SHA ebd38a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41f3219 - Browse repository at this point
Copy the full SHA 41f3219View commit details -
Configuration menu - View commit details
-
Copy full SHA for a84d7e6 - Browse repository at this point
Copy the full SHA a84d7e6View commit details
Commits on Oct 9, 2020
-
ENH: support exporting barplots in SVG!
Need to use paths for circular barplot curves, and maybe better stuff for rect barplots. but it works :D
Configuration menu - View commit details
-
Copy full SHA for 3a69fd8 - Browse repository at this point
Copy the full SHA 3a69fd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad93456 - Browse repository at this point
Copy the full SHA ad93456View commit details -
Configuration menu - View commit details
-
Copy full SHA for f368f2e - Browse repository at this point
Copy the full SHA f368f2eView commit details -
MNT: apply shape-rendering to SVG
shoutouts to https://stackoverflow.com/a/53309814/10730311. this is very easy to configure (just a line in the svg header), so if users prefer different things we can document this.
Configuration menu - View commit details
-
Copy full SHA for 3bf35dc - Browse repository at this point
Copy the full SHA 3bf35dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c45cc9 - Browse repository at this point
Copy the full SHA 5c45cc9View commit details
Commits on Oct 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 32d4185 - Browse repository at this point
Copy the full SHA 32d4185View commit details -
MNT: attempt to fix bounding box stuff
export is broken (height is somehow nan?) but at least this works now
Configuration menu - View commit details
-
Copy full SHA for f10dc88 - Browse repository at this point
Copy the full SHA f10dc88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ed4f8a - Browse repository at this point
Copy the full SHA 5ed4f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52c0587 - Browse repository at this point
Copy the full SHA 52c0587View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6575c6b - Browse repository at this point
Copy the full SHA 6575c6bView commit details -
PERF/BUG: don't even draw 0-length barplots
previously they were showing up in the SVG, probs due to precision pbms. should beo k now
Configuration menu - View commit details
-
Copy full SHA for 5f8580b - Browse repository at this point
Copy the full SHA 5f8580bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e0d001 - Browse repository at this point
Copy the full SHA 3e0d001View commit details -
Configuration menu - View commit details
-
Copy full SHA for 916261e - Browse repository at this point
Copy the full SHA 916261eView commit details
Commits on Oct 14, 2020
-
still gotta test, tho, which will likely need to be deferred until after fixing the other pbms with this pr and tests .______.
Configuration menu - View commit details
-
Copy full SHA for 878854a - Browse repository at this point
Copy the full SHA 878854aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57816f1 - Browse repository at this point
Copy the full SHA 57816f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae1f875 - Browse repository at this point
Copy the full SHA ae1f875View commit details -
Configuration menu - View commit details
-
Copy full SHA for c810859 - Browse repository at this point
Copy the full SHA c810859View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd57583 - Browse repository at this point
Copy the full SHA bd57583View commit details
Commits on Oct 15, 2020
-
MNT: redo public attr stuff with a func approach
is safer -- delegates checking that colorer is continuous to, well, colorer.
Configuration menu - View commit details
-
Copy full SHA for 7b05450 - Browse repository at this point
Copy the full SHA 7b05450View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7c0ac6 - Browse repository at this point
Copy the full SHA e7c0ac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb64e6d - Browse repository at this point
Copy the full SHA eb64e6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97508e4 - Browse repository at this point
Copy the full SHA 97508e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf2c3f1 - Browse repository at this point
Copy the full SHA cf2c3f1View commit details -
MNT: Drastically simplify legend exporting
At least for cat legends -- no longer do we have to worry about rows and units and all that. each legend just returns its width and height, and that's all we care about.
Configuration menu - View commit details
-
Copy full SHA for cf1573e - Browse repository at this point
Copy the full SHA cf1573eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d667cc4 - Browse repository at this point
Copy the full SHA d667cc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d54fa6 - Browse repository at this point
Copy the full SHA 9d54fa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1803ad3 - Browse repository at this point
Copy the full SHA 1803ad3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbc27a9 - Browse repository at this point
Copy the full SHA cbc27a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b94430 - Browse repository at this point
Copy the full SHA 6b94430View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2044f1 - Browse repository at this point
Copy the full SHA b2044f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2c2860 - Browse repository at this point
Copy the full SHA b2c2860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f161cb - Browse repository at this point
Copy the full SHA 8f161cbView commit details
Commits on Oct 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2a8acf3 - Browse repository at this point
Copy the full SHA 2a8acf3View commit details -
MNT: Move radius bb expansion to sep function
addresses a comment from @kwcantrell
Configuration menu - View commit details
-
Copy full SHA for 5c94685 - Browse repository at this point
Copy the full SHA 5c94685View commit details -
PERF: don't cache barplot buffer
addresses @kwcantrell comment. Required breaking up the barplot drawing stuff into a separate function that returns the coords
Configuration menu - View commit details
-
Copy full SHA for 304a854 - Browse repository at this point
Copy the full SHA 304a854View commit details -
BUG: fix reversed continuous color map legends
tldr gotta reverse the stop colors. reason this worked _before_ was that it was accessing the interpolator to build up the stop colors
Configuration menu - View commit details
-
Copy full SHA for f68dc64 - Browse repository at this point
Copy the full SHA f68dc64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d0a4be - Browse repository at this point
Copy the full SHA 5d0a4beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 622997c - Browse repository at this point
Copy the full SHA 622997cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23d4938 - Browse repository at this point
Copy the full SHA 23d4938View commit details
Commits on Nov 3, 2020
-
MNT: Simplify gradient ID / suffix stuff
Addresses @kwcantrell comment.
Configuration menu - View commit details
-
Copy full SHA for 367789a - Browse repository at this point
Copy the full SHA 367789aView commit details
Commits on Nov 5, 2020
-
Merge branch 'master' of https://github.com/biocore/empress into quic…
…k-fixes knock on wood
Configuration menu - View commit details
-
Copy full SHA for d83f9af - Browse repository at this point
Copy the full SHA d83f9afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 033f420 - Browse repository at this point
Copy the full SHA 033f420View commit details