Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting all barplot legends, including color gradient and length legends; export collapsed clade shapes and barplots #392

Merged
merged 62 commits into from
Nov 5, 2020

Commits on Sep 23, 2020

  1. Configuration menu
    Copy the full SHA
    46cd6a3 View commit details
    Browse the repository at this point in the history
  2. BUG: Fix legend SVG title centering; <g> => <svg>

    Also added a newline after </style>
    fedarko committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3d61289 View commit details
    Browse the repository at this point in the history
  3. BUG: Improve legend SVG for SVG importers

    -Use "long form" font specification for the style SVG (fixes problems
     with GIMP and Inkscape)
    -Put the style code higher up in the output legend SVG -- has the
     effect of applying the rect stroke to the topmost legend rect, which
     was a problem in Inkscape but not in chromium (:thonk:)
    -Add note about GIMP choking on dominant-baseline (tldr not worth
     worrying abt now i think)
    fedarko committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    55a2ed1 View commit details
    Browse the repository at this point in the history
  4. STY: reorder/split up text and .title svg styles

    (the text styles are now across multiple lines)
    fedarko committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    52f483e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. MNT: hang on to continuous props in Legend for SVG

    similar to what we do for categorical export
    fedarko committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    77c555a View commit details
    Browse the repository at this point in the history
  2. ENH: add newlines to within gradient svgs

    make life less painful (tm)
    fedarko committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    e5a3e54 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d571dcd View commit details
    Browse the repository at this point in the history
  4. MNT: Refactor colorer/legend handling of gradients

    Now, things are split up into a "Solo" and "HTML" SVG -- the gradient
    shown on the page is a combo of these, and the one we export is just
    the Solo one. This makes scaling it properly for the export SO MUCH
    EASIER AHH
    
    All we gotta do now is just add in value text and update rowsUsed /
    maxLineWidth. think that should be good?
    
    oh also this is gonna explode the tests ofc. that is a job for TOMORROW
    MARCUS (tm)
    fedarko committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    fca7bae View commit details
    Browse the repository at this point in the history
  5. ENH: Finish? gradient legend SVG exporting!

    IT WORKS SO WELL AOGIHDSOIGHJ
    
    something worth noting: there seems to be some unaccounted-for
    horizontal padding on the right side in the cat legend export.
    i matched it in the continuous legend export b/c it looks nice but
    worth looking into...?
    fedarko committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    79d9602 View commit details
    Browse the repository at this point in the history
  6. MNT: add explicit padding to right side of cat SVG

    it looks like things are the opposite from how i thought -- looks like
    the perceived extra space was just due to the boldfont used in
    estimating the texts (when you make the text bold it's almost snug
    with the border on the right side). may as well add the same padding
    as for the continuous legends so things look consistent ish.
    
    Still, this leaves it kinda unclear as to why continuous legends were
    so comparatively snug with the border until i added padding ... maybe
    boldface numbers are just not that bigger? idk
    
    UPDATE: yeah i checked it and bold numbers are basically the same size
    but bold letters are much larger. mystery solved 💯
    fedarko committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    766158e View commit details
    Browse the repository at this point in the history
  7. ENH: initial support for exporting length legends

    looks not great (gotta align max and min headers like in table)
    but good enough tm
    fedarko committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    6c04c35 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c7f54c5 View commit details
    Browse the repository at this point in the history
  9. STY: pret

    fedarko committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    49828bb View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Configuration menu
    Copy the full SHA
    f6ceff3 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Configuration menu
    Copy the full SHA
    4789630 View commit details
    Browse the repository at this point in the history
  2. ENH: export collapsed clade shapes! biocore#303

    Actually not that bad. wack.
    fedarko committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    93531a8 View commit details
    Browse the repository at this point in the history
  3. ENH: draw full rectangle for unrooted collapsing

    removes line in the middle
    fedarko committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    1e0f034 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ebd38a6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    41f3219 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a84d7e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. ENH: support exporting barplots in SVG!

    Need to use paths for circular barplot curves, and maybe better
    stuff for rect barplots. but it works :D
    fedarko committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    3a69fd8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad93456 View commit details
    Browse the repository at this point in the history
  3. PERF: Only specify stroke width for thick lines

    since default is 1
    fedarko committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    f368f2e View commit details
    Browse the repository at this point in the history
  4. MNT: apply shape-rendering to SVG

    shoutouts to https://stackoverflow.com/a/53309814/10730311.
    
    this is very easy to configure (just a line in the svg header),
    so if users prefer different things we can document this.
    fedarko committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    3bf35dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5c45cc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Configuration menu
    Copy the full SHA
    32d4185 View commit details
    Browse the repository at this point in the history
  2. MNT: attempt to fix bounding box stuff

    export is broken (height is somehow nan?) but at least this works now
    fedarko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    f10dc88 View commit details
    Browse the repository at this point in the history
  3. STY: prettify

    fedarko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    5ed4f8a View commit details
    Browse the repository at this point in the history
  4. negate y coords and declare maxy in bb

    still broken but much less so
    fedarko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    52c0587 View commit details
    Browse the repository at this point in the history
  5. Space out adjacent polygon pts

    fixes things! hey this works now
    fedarko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    6575c6b View commit details
    Browse the repository at this point in the history
  6. PERF/BUG: don't even draw 0-length barplots

    previously they were showing up in the SVG, probs due to precision
    pbms. should beo k now
    fedarko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    5f8580b View commit details
    Browse the repository at this point in the history
  7. STY: prett

    fedarko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    3e0d001 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    916261e View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. BUG: Fix biocore#421

    still gotta test, tho, which will likely need to be deferred until
    after fixing the other pbms with this pr and tests .______.
    fedarko committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    878854a View commit details
    Browse the repository at this point in the history
  2. TST: fix a gradient svg test

    fedarko committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    57816f1 View commit details
    Browse the repository at this point in the history
  3. specify combined svg

    fedarko committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    ae1f875 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c810859 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd57583 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. MNT: redo public attr stuff with a func approach

    is safer -- delegates checking that colorer is continuous to, well,
    colorer.
    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    7b05450 View commit details
    Browse the repository at this point in the history
  2. TST: unbreak colorer tests!

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    e7c0ac6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb64e6d View commit details
    Browse the repository at this point in the history
  4. TST: unbreak legend tests :D

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    97508e4 View commit details
    Browse the repository at this point in the history
  5. STY: prettify tests

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    cf2c3f1 View commit details
    Browse the repository at this point in the history
  6. MNT: Drastically simplify legend exporting

    At least for cat legends -- no longer do we have to worry about
    rows and units and all that. each legend just returns its width and
    height, and that's all we care about.
    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    cf1573e View commit details
    Browse the repository at this point in the history
  7. STY: pret

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    d667cc4 View commit details
    Browse the repository at this point in the history
  8. UNBREAK CONTINUOUS LEGENDS :D

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    9d54fa6 View commit details
    Browse the repository at this point in the history
  9. Fix length legends

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    1803ad3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    cbc27a9 View commit details
    Browse the repository at this point in the history
  11. DOC: fix some docs stuff

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    6b94430 View commit details
    Browse the repository at this point in the history
  12. fix stats format

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    b2044f1 View commit details
    Browse the repository at this point in the history
  13. populateTreeStats fixes

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    b2c2860 View commit details
    Browse the repository at this point in the history
  14. STY: whoops

    fedarko committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    8f161cb View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Configuration menu
    Copy the full SHA
    2a8acf3 View commit details
    Browse the repository at this point in the history
  2. MNT: Move radius bb expansion to sep function

    addresses a comment from @kwcantrell
    fedarko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5c94685 View commit details
    Browse the repository at this point in the history
  3. PERF: don't cache barplot buffer

    addresses @kwcantrell comment. Required breaking up the barplot
    drawing stuff into a separate function that returns the coords
    fedarko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    304a854 View commit details
    Browse the repository at this point in the history
  4. BUG: fix reversed continuous color map legends

    tldr gotta reverse the stop colors. reason this worked _before_ was
    that it was accessing the interpolator to build up the stop colors
    fedarko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    f68dc64 View commit details
    Browse the repository at this point in the history
  5. simplify grad svg code a bit

    fedarko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5d0a4be View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    622997c View commit details
    Browse the repository at this point in the history
  7. STY

    fedarko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    23d4938 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. MNT: Simplify gradient ID / suffix stuff

    Addresses @kwcantrell comment.
    fedarko committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    367789a View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Configuration menu
    Copy the full SHA
    d83f9af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    033f420 View commit details
    Browse the repository at this point in the history