-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions #465
GitHub actions #465
Conversation
…into github-actions
Thanks for this, @kwcantrell! One thing I just realized is that we will probably also want to update the README to remove the Travis build embedding at the top. Do you know if there's an equivalent for GH actions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't seen conda run
before, that is nifty. I took a different approach with microsetta public API (https://github.com/biocore/microsetta-public-api/blob/master/.github/workflows/python-package-conda.yml#L37-L40), where the environment is activated, but this seems much much cleaner!
|
||
- name: Create Qiime enviroment | ||
run: | | ||
wget https://data.qiime2.org/distro/core/qiime2-2020.6-py36-linux-conda.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 2020.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using the latest version (https://raw.githubusercontent.com/qiime2/environment-files/master/latest/staging/qiime2-latest-py36-linux-conda.yml) and it was working fine but all of a sudden it started to break the build and causing it to fail. So I switched to 2020.6 simply because that is the version I am using on my local machine.
Thats a good point, I didn't even think about that. The CONTRIBUTING.md also needs to be updated. |
Thanks @kwcantrell, I agree with @gibsramen regarding updating the contribution documentation. |
Looks like we can update with GitHub's own status badges. |
Thanks everyone for the feedback. The PR should now be good to merge. |
Thanks so much @kwcantrell!! 🚀 Let's start with this config file and see what else is revealed along the way 👍 |
this pr "translates" our travis yml file to a github actions yml file.
Its currently setup to trigger when ever a pull request on the master branch is create or when pull requests are updated.
I currently have the step that adds McHelper commented out. We should be able to uncomment it out once we resolve the issue with McHelper.