New color map #483
Merged
New color map #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedarko
requested changes
Feb 10, 2021
|
@fedarko thanks for reviewing this! I think I have addressed all of your comments. |
fedarko
reviewed
Feb 22, 2021
There was a problem hiding this comment.
Thanks @kwcantrell! This looks great -- I have one suggestion, but we could probably merge this in even without it.
fedarko
reviewed
Feb 23, 2021
empress/support_files/js/colorer.js
Outdated
| @@ -553,6 +565,8 @@ define(["chroma", "underscore", "util"], function (chroma, _, util) { | |||
| "#808000", | |||
| "#008080", | |||
| ]; | |||
| Colorer.__GR_OR_PR = "GnOrPr"; | |||
There was a problem hiding this comment.
Suggested change
| Colorer.__GR_OR_PR = "GnOrPr"; | |
| Colorer.__GN_OR_PR = "GnOrPr"; |
Just to make this consistent with Colorer.__gnOrPr -- if we use different abbreviations i suspect it'll cause problems down the line
empress/support_files/js/colorer.js
Outdated
| @@ -244,7 +251,12 @@ define(["chroma", "underscore", "util"], function (chroma, _, util) { | |||
| } else { | |||
| domain = [min, max]; | |||
| } | |||
| var interpolator = chroma.scale(this.color).domain(domain); | |||
| var interpolator; | |||
| if (this.color === Colorer.__GR_OR_PR) { | |||
There was a problem hiding this comment.
Suggested change
| if (this.color === Colorer.__GR_OR_PR) { | |
| if (this.color === Colorer.__GN_OR_PR) { |
empress/support_files/js/colorer.js
Outdated
| @@ -175,15 +175,22 @@ define(["chroma", "underscore", "util"], function (chroma, _, util) { | |||
| ); | |||
| } | |||
|
|
|||
| var interpolator; | |||
| if (this.color === Colorer.__GR_OR_PR) { | |||
There was a problem hiding this comment.
Suggested change
| if (this.color === Colorer.__GR_OR_PR) { | |
| if (this.color === Colorer.__GN_OR_PR) { |
Nitpick away :) It should be fixed now. |
|
Perfect, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new custom diverging color map (green to light orange to purple) that is great for coloring tree branches as a lot of the other diverging color maps are either hard to see the separation of values and/or the middle values are colored to light which makes the branches hard to see.
You can see that this color map does a good job separating the two extreme values (i.e. endpoints) from the middle values while still making everything visible on screen.