Dynamic bp tree #490
Merged
Dynamic bp tree #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElDeveloper
requested changes
Mar 2, 2021
There was a problem hiding this comment.
Looks great @kwcantrell, I just added a few small comments.
| deepEqual(result.b_, [1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 0, 0]); | ||
| deepEqual(result.names_, [null, "7", "10", "11", "9", "8", "r"]); | ||
| deepEqual(result.lengths_, [null, 6, 7, 8, 9, 10, 11]); | ||
| }); |
There was a problem hiding this comment.
@kwcantrell can you add a test case for when all tips are removed?
empress/support_files/js/bp-tree.js
Outdated
|
|
||
| // get name and length of node | ||
| // Note: names and lengths of nodes are stored in postorder | ||
|
|
empress/support_files/js/bp-tree.js
Outdated
| @@ -971,5 +971,64 @@ define(["ByteArray", "underscore"], function (ByteArray, _) { | |||
| return this._nameToNodes[name]; | |||
| }; | |||
|
|
|||
| /** | |||
| * tips - Set | |||
There was a problem hiding this comment.
Can you fill the rest of the documentation?
|
This looks awesome!!! +1 |
|
Thanks so much @wasade. @kwcantrell, it looks like there's only a handful of comments from my review but otherwise this should be good to be merged. |
ElDeveloper
approved these changes
Mar 10, 2021
|
Thanks @kwcantrell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a shear method for the bp tree that is based on https://github.com/wasade/improved-octo-waddle/blob/master/bp/_bp.pyx#L732
@wasade if you can take a look at this that would be awesome!