Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add to citations.bib for QIIME2 #494

Merged
merged 6 commits into from
Mar 19, 2021

Conversation

ElDeveloper
Copy link
Member

No description provided.

Copy link
Collaborator

@fedarko fedarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ElDeveloper! One small fix to @kwcantrell's name in the citation title :)

Do you think we should keep the other 3 references (Gneiss, BP, Striped UniFrac) around in citations.bib? Now that the paper is published (citing all 3 of these in some way), I'm not sure users of the tool necessarily need to cite all of these 3 references in addition to EMPress itself. I'm not sure what the proper etiquette here is, though :)

README.md Outdated Show resolved Hide resolved
empress/citations.bib Outdated Show resolved Hide resolved
ElDeveloper and others added 4 commits March 17, 2021 19:43
Co-authored-by: Marcus Fedarko <marcus.fedarko@gmail.com>
Co-authored-by: Marcus Fedarko <marcus.fedarko@gmail.com>
@ElDeveloper
Copy link
Member Author

I don't think there's a citation etiquette, but I think leaving just the EMPress citation makes sense.

@emperor-helper
Copy link

The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv

@fedarko fedarko merged commit c00c3f9 into biocore:master Mar 19, 2021
@fedarko
Copy link
Collaborator

fedarko commented Mar 19, 2021

Thanks @ElDeveloper! (and @emperor-helper 🐧 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants