Fix bug with running standalone version; account for NumPy dependency in standalone install instructions; a few small changes w/r/t node circle options #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-for-standalone-2
Forgot to account for chicken-and-egg NumPy problem we ran into with Qurro. This should fix it.
fedarko
changed the title
Not very related to this PR but still wanted to address
I think this ordering makes the most sense
fedarko
changed the title
|
Thanks @fedarko ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a line in
_plot_utils.pythat importsq2templates, a package which is (usually) only available in QIIME 2 conda environments. This was breaking the standalone script when ran outside of a QIIME 2 environment.To fix this, we can just move the import down so that it's only done if EMPress is being run through QIIME 2. This fixes the problem.
A very warm thank you to @ammaraziz for pointing this out!
Edit - I also made a few changes in this PR's later commits that make the UI for changing the node circle behavior a bit nicer. Should be limited to just cosmetic changes to the HTML.