Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Small tweaks to GH Actions workflows #502

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

fedarko
Copy link
Collaborator

@fedarko fedarko commented Mar 19, 2021

Nothing big, just some small fixes that should make development easier.

  • Remove Node.js matrix for main CI, since the version number is hard-coded currently; this should remove the need to click through multiple pages when accessing the main CI (edit: actually maybe you still need to click through things twice, hm. at least it should simplify the code.)

    • In the future we could add back this matrix and use it to try multiple Node.js versions -- however I don't think it's an urgent priority, since Node.js is only used on the development side (so being exhaustive about versions working probably isn't too important, at least compared to Python versions in the standalone CI)
    • Another concern here is that trying multiple Node.js versions should probably be a separate process from installing/testing the Python code; I think the most efficient way to set this up this would be something like adding a different workflow for JS testing, then adding another workflow for uploading to McHelper that is dependent on both the "JS testing" and "Python testing" workflows passing [but IDK how to do that right now]
  • Make some documentation consistent btwn YAML files (e.g. Empress -> EMPress)

  • Remove the "Empress" from the workflow names, renaming them to just "Main CI" and "Standalone CI" -- I think this makes the README badges/etc. easier to interpret

- Remove Node.js matrix for main CI, since the version number is
  hard-coded in anyway
- Make some documentation consistent btwn YAML files (e.g. Qiime ->
  QIIME 2)
- Rename CIs to just "Main CI" and "Standalone CI", which I think
  makes the README badges / etc. easier to interpret
@emperor-helper
Copy link

The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv

@ElDeveloper
Copy link
Member

Thanks @fedarko !

@ElDeveloper ElDeveloper merged commit 29fc915 into biocore:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants