BUG: Draw node circles as needed in SVG export #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that node circles were being left out of the SVG tree export, even when node circles are explicitly enabled for some or all nodes.
I believe this was happening because
export-util.jshadn't been updated in light of #486's changes:empress/empress/support_files/js/export-util.js
Line 337 in df3a4da
The
Drawer.showTreeNodesflag was removed in #486, so I guess thanks to Javascript's magicif (drawer.showTreeNodes)will always silently evaluate toundefined(aka false) ._.This PR fixes this problem. Fortunately, the way #486 is set up seemed to make it pretty easy to get this working again.