Projects list #51
Merged
Projects list #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server-side input, and to set up create/edit modal with current state filled from table row when editing.
…item with "manage projects"
…nt, update api calls to modified urls
…or responses (which cause jsondecoder to throw its OWN error)
… apparently datatables actually removes the hidden columns from the dom, meaning I can't capture their contents from the tr to prepopulate the update modal
…into projects_list
…into projects_list
…into projects_list
…into projects_list
… added comments to javascript
…late for consistency
dhakim87
reviewed
Sep 10, 2020
dhakim87
reviewed
Sep 10, 2020
dhakim87
reviewed
Sep 10, 2020
dhakim87
reviewed
Sep 10, 2020
dhakim87
reviewed
Sep 10, 2020
dhakim87
approved these changes
Sep 10, 2020
|
Thanks, @AmandaBirmingham! I don't see any issues. Has Edgar and/or Se Jin seen the final form yet by chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the front-end changes that go with the microsetta-private-api PR #254. This PR replaces the existing "create project" menu item and page with a new "manage projects" menu item and page. Includes a sortable, searchable, column-subsetable list of projects as well as the ability to create and update projects. The load from the back end is kind of slow (see microsetta-private-api PR #254 for more on that) so also shows a wait dialog whenever this page is loaded/reloaded so users know the site isn't just hanging.