Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified the way assigning numbers for unique names #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qiyunzhu
Copy link

Edited make_names_unique.
Before: Clostridia, Clostridia_1, Clostridia_2, Clostridia_3...
After: Clostridia_1, Clostridia_2, Clostridia_3, Clostridia_4...

@qiyunzhu
Copy link
Author

Since the original code was too long ago, it won't pass the current Travis test. First error message is Error: HTTPError: 403 Forbidden http://repo.continuum.io/pkgs/pro/linux-64/. There will be a lot more, including non-PEP8 styles.

@qiyunzhu
Copy link
Author

Also fixed the bug we discussed on Nov. 17, 2017.

@sjanssen2
Copy link
Contributor

@qiyunzhu I want to see how much work it is to migrate this repo to python 3. Might help if you ping Daniel to draw some attention to this task. Hopefully, we than can also work in your updates.

@qiyunzhu
Copy link
Author

@sjanssen2 I talked with @wasade . He said this 2-to-3 translation effort will be fantastic. Though nobody is currently working on it. Not sure how much work would that be.

@sjanssen2
Copy link
Contributor

Good morning @wasade and @qiyunzhu

It is already done. I just wait for reviews :-)
First step is to update to more recent skbio version PR #28 and if this goes through, another update is awaiting being pushed. I am using the py35 version of tax2tree already for tax-credit.

Best,
Stefan

@wasade
Copy link
Member

wasade commented Jul 18, 2018

Just merged #28, thank you @sjanssen2 and @qiyunzhu! I'm excited to see some life come back into this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants