Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group k for Unweighted on GPU #68

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Group k for Unweighted on GPU #68

wants to merge 37 commits into from

Conversation

sfiligoi
Copy link
Collaborator

By grouping indexes that have zero-sum, we minimize divergence of GPU warps.
This gives a noticeable speedup in Unweighted (due to expensive pseudo-random lookup for some paths).
Not done for Weighted, since it uses a more regular memory pattern that would be disrupted by grouping.

sfiligoi added 30 commits January 30, 2025 15:31
@sfiligoi
Use a single acc_nv for both OpenACC and OMPGPU. Preliminary support …
37d271e 
…for acc_amd
@sfiligoi
Do not explicitly source the nv setup script in the Makefile
ab393ab
@sfiligoi
Switch form BUILD_OFFLOAD to BUILD_NV_OFFLOAD. Only build all_nv if N…
bccccd1 
…V_CXX defined
@sfiligoi
Always build acc_nv on Linux
e58031d
@sfiligoi
Add support for AMD GPU compilation
c8dedf1
@sfiligoi
Add install_amd_clang.sh and use in CI
3b571f1
@sfiligoi
Make BUILD_NV_OFFLOAD and BUILD_AMD_OFFLOAD optional
5e521bd
@sfiligoi
Fix typo
7e0dfc6
@sfiligoi
Clarify which GPU is used
ba0f00a
@sfiligoi
Properly build test_binaries last on Linux
e4a1ae1
@sfiligoi
Use curl instead of wget
e3684ee
@sfiligoi
Enable curl link following, and use apt install
f529184
@sfiligoi
Better handle failure in installing gpu compilers
408309a
@sfiligoi
Update README with AMD complier instructions
adf33aa
@sfiligoi
Improve installation instructions in README
23b542a
@sfiligoi
Add uprivileged install fallback in scripts/install_amd_clang.sh
155853d
@sfiligoi
Add support for UNIFRAC_USE_NVIDIA_GPU and UNIFRAC_USE_AMD_GPU. Docum…
664a38c 
…ent clean_install
@sfiligoi
Fix typo
3cb1977
@sfiligoi
Update NV setup script to download the latest version
25beb33
@sfiligoi
Improve build docs
99dd51b
@sfiligoi
Remove popcnt-based selection
9389792
@sfiligoi
Transpose embedded_proportions for non-Vaw and non-binary variants
0f87955
@sfiligoi
Tune emb size for new access pattern
58c97c2
@sfiligoi
Fix preprocesssor check
f5407d9
@sfiligoi
NVCC happier when one does not specify vector_length explicitly
e84beae
@sfiligoi
Explicitly request vectorization in WeightedVal1
e158991
@sfiligoi
Use the (old) straight logic for the GPUs
432a28e
@sfiligoi
Tune RECOMMENDED_MAX_EMBS_BOOL for CPUs
64ff847
@sfiligoi
NVCC happier when one does not specify vector_length explicitly
82c9345
@sfiligoi
Use transposed emb in CPU version of unweighted
66d5b2d
@sfiligoi sfiligoi marked this pull request as draft February 22, 2025 01:42
@sfiligoi
Copy link
Collaborator Author

On a RTX4060,
Unweighted EMP goes from 36s to 29s
Unweighted AG goes from 116s to 96s.

@sfiligoi
Copy link
Collaborator Author

On the 780M iGPU, part of AMD Ryzen 9 7940HS
Unweighted EMP goes from 129s to 115s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfiligoi