support oncokb agent and agent selector #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengsh27
commented
Aug 6, 2024
| item: ChatCompletionsPostModel, | ||
| # request: Request, # ChatCompletionsPostModel, | ||
| # item: ChatCompletionsPostModel, | ||
| request: Request, # ChatCompletionsPostModel, |
There was a problem hiding this comment.
Here we go back to Request due to the connection issue. If we use ChatCompletionsPostModel, biochatter-next can't communicate in this endpoint, which is a bug, and I'll fix it in next PR.
slobentanzer
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
@fengsh27 thanks; I merged use_reflexion in biochatter, so it makes sense to merge here as well, right? Should we merge and bump minor version here, or do we need to wait for other changes?
|
@slobentanzer I updated biochatter version to 0.7.3, and now we are ready to merge to main |
|
merging, bumping to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This submission is to support OncoKB API agent and Rag Agent selector. To achieve this, this submission introduced the following parameters when requesting chat completion:
1). useKG, kgConfig
2). useRag, ragConfig
3). oncokbConfig
4). useAutoAgent
Regarding individual agents, the rule that determines if the agent is enabled:
**Config is not None and (useAutoAgent or useXxx).For example, in the case KG,