Update review instructions #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fynn Beuttenmüller <thefynnbe@gmail.com>
Co-authored-by: Fynn Beuttenmüller <thefynnbe@gmail.com>
Co-authored-by: Fynn Beuttenmüller <thefynnbe@gmail.com>
Co-authored-by: Fynn Beuttenmüller <thefynnbe@gmail.com>
|
@k-dominik please review my added changes in e07f21a |
k-dominik
commented
Jul 2, 2024
Comment on lines
+28
to
+29
| A bioimage.io resource is created by a user uploading a _resource package_. | ||
| Such a _resource package_ could e.g. be a newly uploaded _model package_, or _notebook package_. |
There was a problem hiding this comment.
so the user is uploading a resource package, but the resource package is already a newly uploaded model package, so uploading twice? ;)
There was a problem hiding this comment.
no any ... package is just a zip file... ?
k-dominik
commented
Jul 2, 2024
k-dominik
commented
Jul 2, 2024
k-dominik
commented
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.