Update package command and clean up root_path #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expecting validate to return errors only
relative root paths cause trouble on windows
as WindowsPath("/Users") is a relative path
WindowsPath("/Users").resolve() adds a drive letter, here: C:\Users
allows for arbitrary uri and enables common download pbar with tqdm
FynnBe
commented
Nov 22, 2021
|
All tests are passing, so good to merge from my side; merge whenever you think this is ready @FynnBe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR
spec.root_pathis always a resolved absolute path** relative root paths cause trouble on windows
as
WindowsPath("/Users").is_absolute() == FalseWindowsPath("/Users").resolve()adds a drive letter and normalizes the path (for windows forward slash to backslash),here:
C:\Users