-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shape val #163
Fix shape val #163
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Switching to the correct return codes has unearthed another bug:
This looks like an old problem that I hoped was fixed .... |
This error stems from our mixed use of the URI classes (node and field) as paths and specifically that we allow relative paths, but no absolute ones. That we ended up with that has historic reasons only (e.g. we tried to avoid the |
Is this fixd by bioimage-io/spec-bioimage-io#287 or do we need to change something else here? |
No, looks like it still fails. |
no, but hopefully by this WIP bioimage-io/spec-bioimage-io#288 and its future equivalent here for bioimageio.core |
Fixes the input/output shape validation which did not work at all; we just did not notice because the tests for
test_model
where also broken...In addition this also fixes the return codes from all CLI functions, which always returned 0 before.