Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to export old versions #188

Merged
merged 6 commits into from
Dec 8, 2021
Merged

Enable to export old versions #188

merged 6 commits into from
Dec 8, 2021

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Dec 7, 2021

needs bioimage-io/spec-bioimage-io#335

This PR enables

  • exporting resource packages without format version update
  • export resource package with specified format version

also updates core to sync with latest bioimageio.spec changes (d63d17e)

@FynnBe FynnBe requested a review from k-dominik December 7, 2021 19:53
Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we merge this now, @FynnBe in order to make a relase that is compatible with spec again?

bioimageio/core/resource_io/io_.py Outdated Show resolved Hide resolved
bioimageio/core/resource_io/io_.py Outdated Show resolved Hide resolved
@constantinpape
Copy link
Contributor

Tests pass now and comments are addressed, I will go ahead and merge this.

@constantinpape constantinpape merged commit b2ab69e into main Dec 8, 2021
@FynnBe FynnBe deleted the export_old_versions branch December 8, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants