Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authors in the yaml and the weights #56

Closed
esgomezm opened this issue Nov 30, 2020 · 2 comments
Closed

Authors in the yaml and the weights #56

esgomezm opened this issue Nov 30, 2020 · 2 comments

Comments

@esgomezm
Copy link
Contributor

Just to agree on the specification of authors to avoid future confusions:

So the idea is that authors in the main one are the ones that created the model and uploaded the model.yaml etc.

I think this can be ambiguous for the cases in which you create a bioimage bundled model from a model that was trained by different people. For example, in DeepImageJ we have some models trained by CSBDeep team but if the user has any problem trying to run them, they should contact us and not CSBDeep. I think @frauzufall can input valuable comments on this as we already got confusions with our model repositories.

After that happens someone else might convert the weights to a different format and then add this to the same model.yaml. In this case, they should be listed here (because they are different from the "main" authors).

I agree with this one.

Originally posted by @constantinpape in #54 (comment)

@constantinpape
Copy link
Collaborator

Thanks for raising the issues, I agree there are some more subtleties...

I think this can be ambiguous for the cases in which you create a bioimage bundled model from a model that was trained by different people. For example, in DeepImageJ we have some models trained by CSBDeep team but if the user has any problem trying to run them, they should contact us and not CSBDeep. I think @frauzufall can input valuable comments on this as we already got confusions with our model repositories.

How about including both parties (the ones that have trained the model and the ones that bundle it for bioimage.io) in this case?

@constantinpape
Copy link
Collaborator

Fixed in #59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants