Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape description and authors #59

Merged
merged 23 commits into from
Dec 18, 2020
Merged

Conversation

constantinpape
Copy link
Collaborator

This PR includes:

  • extension of the shape description based on the work by @esgomezm in Extend description #54
  • update to the author fields and introduction of the parent fields

Please have a look if this reflects what we agreed upon in the meeting today and feel free to suggest changes, @esgomezm @oeway @frauzufall.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
constantinpape and others added 3 commits December 7, 2020 13:24
Co-authored-by: FynnBe <thefynnbe@gmail.com>
Co-authored-by: FynnBe <thefynnbe@gmail.com>
@constantinpape
Copy link
Collaborator Author

@esgomezm @frauzufall
What do you think about the changes here?
Is there still something you want to discuss in today's meeting or should we merge it before that?

README.md Outdated Show resolved Hide resolved
@constantinpape
Copy link
Collaborator Author

@oeway @fjug @tomburke-rse @frauzufall @FynnBe @esgomezm
I updated the PR to reflect the changes to parent and data_type / data_range we discussed today.
I think this PR should include the changes necessary to finalize 0.3.0 now.

Let me know if you approve / if there is still something that needs to change from your side.

@oeway
Copy link
Contributor

oeway commented Dec 11, 2020

Ok, thanks! Could you please also take a look at #60 ?

supported_formats_and_operations.md Show resolved Hide resolved
supported_formats_and_operations.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@FynnBe
Copy link
Member

FynnBe commented Dec 18, 2020

Should we add a default eps value for zero_mean_unit_variance (and future eps kwargs elsewhere?). 0.0 or smth like 1.0e-6?
I think a value >0 would help to get closer outputs across implementations...

Copy link

@fjug fjug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, really late... my bad...
As far as I can see, neither Tom or myself see any fundamental problem.
(But we are sure that @frauzufall might disagree in January... and that is likely good!)

Unifying Pre- and Postprocessing
@constantinpape
Copy link
Collaborator Author

Ok, I think we resolved this and I am merging this 🎉 !
We should be ready for 0.3.0 now, I will clean up issues and make a release later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants