-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shape description and authors #59
Conversation
Co-authored-by: FynnBe <thefynnbe@gmail.com>
Co-authored-by: FynnBe <thefynnbe@gmail.com>
@esgomezm @frauzufall |
@oeway @fjug @tomburke-rse @frauzufall @FynnBe @esgomezm Let me know if you approve / if there is still something that needs to change from your side. |
Ok, thanks! Could you please also take a look at #60 ? |
Should we add a default |
Co-authored-by: FynnBe <thefynnbe@gmail.com>
Co-authored-by: FynnBe <thefynnbe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, really late... my bad...
As far as I can see, neither Tom or myself see any fundamental problem.
(But we are sure that @frauzufall might disagree in January... and that is likely good!)
Unifying Pre- and Postprocessing
Ok, I think we resolved this and I am merging this 🎉 ! |
This PR includes:
author
fields and introduction of theparent
fieldsPlease have a look if this reflects what we agreed upon in the meeting today and feel free to suggest changes, @esgomezm @oeway @frauzufall.