-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public s3 prefix without auth #26
Conversation
Draft PR until #24 is merged. |
Previously Dan asked:
And I answered: They must either provide AWS credentials or set So if we wanted to improve the usability I think it happens in try:
# __init__ with user's fs_kwargs
except SomethingSpecific as e:
if protocol == "s3://":
# __init__ with user's fs_kwargs plus {anon: True}
else:
raise e |
"fsspec>=2022.8.0", | ||
"ome-zarr>=0.9.0", | ||
"xarray>=0.16.1", | ||
"zarr>=2.18.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isnt this a dependency of ome-zarr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I believe so, but now we are using it directly
…fix-without-auth-tmp
```python | ||
from bioio import BioImage | ||
path = "https://allencell.s3.amazonaws.com/aics/nuc-morph-dataset/hipsc_fov_nuclei_timelapse_dataset/hipsc_fov_nuclei_timelapse_data_used_for_analysis/baseline_colonies_fov_timelapse_dataset/20200323_09_small/raw.ome.zarr" | ||
image = BioImage(path) | ||
print(image.get_image_dask_data()) | ||
``` | ||
If using an `s3://` path to access a public S3 bucket, the `BioImage` constructor must be given a dictionary with `anon: True` in the `fs_kwargs` argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good and valuable documentation but slightly unfortunate that it lives here in the reader's README. It would be great if somewhere in the bioio docs we said something like "be sure to check the readmes or documentation for individual readers, for their specific parameters." It might already be there... This is just an occupational hazard of having readers in separate packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular piece of documentation may apply to all/many readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed an issue for it bioio-devs/bioio#60
Trying again to do #25 but with the tests fixed this time!
Context
Previously bioio could not read from a public
s3://
URL without AWS authentication due to this ome-zarr issue. As of0.9.0
the issue is resolved.Changes
ome-zarr
dependencyome-zarr
instead of just a paths3://
URLTesting
pdm run pytest bioio_ome_zarr/tests/test_s3_read.py