Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI from Travis to Github Actions #71

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Nov 17, 2021

Fixes #70

@heuermh heuermh added this to the 1.9.6 milestone Nov 17, 2021
@heuermh
Copy link
Member Author

heuermh commented Nov 17, 2021

@josemduarte Sorry to ping you on old biojava-legacy stuff!

For some reason Github Actions didn't pick up and run CI on this pull request. I just did the same thing on a repository I own ten minutes ago and GA picked it up right away.

heuermh/velocity-cli#18
https://github.com/heuermh/velocity-cli/actions

Have I missed some configuration setting? Thanks in advance

@josemduarte
Copy link

Yes setting github actions CI can be complicated. It took me forever to get it running in biojava...

Did you check the protected branch settings? That's also necessary for PRs to run the tests I believe. This is how it looks like in biojava:
Screen Shot 2021-11-17 at 21 57 57

@heuermh
Copy link
Member Author

heuermh commented Nov 18, 2021

If I look there it says no status checks found. I am guessing it is a permissions issue, pull request from a fork against an organizational repository ... although I also enabled Github Actions for our bigdatagenomics repositories recently and didn't run into this.

bigdatagenomics/adam#2311

@josemduarte
Copy link

If I look there it says no status checks found.

That's something I also encountered and struggled with. They weren't there but eventually the available status checks appeared.

My theory is that the system becomes aware of them only when the CI pipeline has actually run somewhere else (e.g. in a push to master).

@heuermh
Copy link
Member Author

heuermh commented Nov 18, 2021

Hmm, that's also what I was thinking. I'll try merging this pull request and see if that kicks anything.

@heuermh heuermh merged commit fba10c4 into biojava:master Nov 18, 2021
@heuermh heuermh deleted the github-actions branch November 18, 2021 17:53
@heuermh
Copy link
Member Author

heuermh commented Nov 18, 2021

The Deploy Snapshot workflow was triggered on merge

https://github.com/biojava/biojava-legacy/actions/runs/1477681785

Guess I'll need to find some bug to fix so that I can create a new pull request 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI from Travis to Github Actions
2 participants