[ENH ] Numpy 2.0 compatibility #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 71.77% 71.79% +0.01%
==========================================
Files 34 34
Lines 9107 9114 +7
==========================================
+ Hits 6537 6543 +6
- Misses 2570 2571 +1 ☔ View full report in Codecov by Sentry. |
Numpy 2.0 changes scalar repr as per:
https://numpy.org/neps/nep-0051-scalar-representation.html
Make matplotlib_export convert to python scalars where appropriate
to avoid 'np.*' in generated code.
|
Seems OK. I tested this with the numpy2 branch from orange3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Numpy 2.0 changes scalar repr as per https://numpy.org/neps/nep-0051-scalar-representation.html
This adds many
np.float64(...)to generated matplotlib_export code.Description of changes
Make matplotlib_export convert to python scalars where appropriate to avoid 'np.*' in generated code.
Includes