Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] GEO Datasets: Move GDSInfo initialization in a worker thread #319

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ales-erjavec
Copy link
Contributor

Issue

GEO Datasets blocks the main thread when first placed on the canvas when it has to download the GDSInfo

Work on top of gh-318

Description of changes

Move the GDSInfo initialization in a worker thread.

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the geo-datasets-init branch 2 times, most recently from 721495f to acdb601 Compare May 12, 2023 09:05
@ales-erjavec ales-erjavec marked this pull request as ready for review May 19, 2023 10:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.58%. Comparing base (b2f9763) to head (1184d2b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   48.47%   48.58%   +0.11%     
==========================================
  Files          67       67              
  Lines       10894    10908      +14     
==========================================
+ Hits         5281     5300      +19     
+ Misses       5613     5608       -5     
Files Coverage Δ
...ngecontrib/bioinformatics/widgets/OWGEODatasets.py 83.93% <87.50%> (+2.49%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f9763...1184d2b. Read the comment docs.

@PrimozGodec PrimozGodec merged commit 08841de into biolab:master Mar 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants