Preprocess Text unable to browse files without ".txt" extension

[chasets]

Text version

0.3.0

Orange version

3.8.0

Additional version information

MacOS 10.12.6
Conda 4.3.29
Python 3.6.0

Expected behavior

In the Preprocess Text widget, the user should be able to choose the folder icon for "Stopwords" or "Lexicon" and browse to a file containing the appropriate text, regardless of the name of the file. This is especially true considering that the included nltk files do not conform to a ".txt" convention.

Actual behavior

The File Chooser only allows selection of files with the ".txt" extension as part of the filename. The files included with orange3-text at nltk_data/corpora/stopwords/* do not include this extension, so they are not available to choose in Preprocess Text.

Steps to reproduce the behavior

1. Add a Corpus widget and choose book-excerpts.tab
2. Connect a Preprocess Text widget
3. Open the Preprocess Text widget and browse to the nltk_data/corpora/stopwords directory
4. None of the files here are available for selection
5. In the OS, rename the file named "english" to "english.txt"
6. Repeat step 3 above
7. The file "english.txt" is available to choose for stopwords

Additional info (worksheets, data, screenshots, ...)

[kernc]

Thanks for the report. Would you like to try submitting a patch fixing the issue?

[chasets]

Sure, I'll give it a shot. I have the fix, now I just need to figure out the submission process.

…

On Thu, Jan 25, 2018 at 2:08 PM, kernc ***@***.***> wrote: Thanks for the report. Would you like to try submitting a patch fixing the issue? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#333 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHMkXH52P7iR-zkrMQZqdu2NqN87_NP_ks5tONEngaJpZM4Rs8uu> .

[kernc]

Any sort of diff patch is fine, but easiest to review and apply would be a pull request here on GitHub. This is the basic workflow:

1. Create a local fork of the repository (Fork button on the top right).
2. Apply changes on a topic branch of your repository.
3. Propose changes as a pull request to this repository.

Here's some commands to go with it. Don't avoid asking if you need help.

[chasets]

Done. I'll await comments at #334

…

--Tim

On Sat, Jan 27, 2018 at 2:04 AM, kernc ***@***.***> wrote: Any sort of diff patch is fine, but easiest to review and apply would be a pull request here on GitHub. This is the basic workflow <https://guides.github.com/introduction/flow/>: 1. Create a local fork of the repository (Fork button on the top right). 2. Apply changes on a topic branch <https://guides.github.com/activities/forking/> of *your* repository. 3. Propose changes as a pull request to this repository. Here's some commands <https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request> to go with it. Don't avoid asking if you need help. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#333 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHMkXD4UDbB8c84xenlPX_mH2sn-9zDpks5tOspogaJpZM4Rs8uu> .