Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic search server communicator #717

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

djukicn
Copy link
Collaborator

@djukicn djukicn commented Sep 10, 2021

Issue

Implements a component that communicates with semantic search API.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec
Copy link
Collaborator

@djukicn It looks good. Can you just add a test or two?

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #717 (cb4d9cb) into master (68941e1) will increase coverage by 0.15%.
The diff coverage is 87.01%.

❗ Current head cb4d9cb differs from pull request most recent head 15ed20a. Consider uploading reports for the commit 15ed20a to get more accurate results

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   74.22%   74.38%   +0.15%     
==========================================
  Files          72       73       +1     
  Lines        9592     9665      +73     
  Branches     1307     1318      +11     
==========================================
+ Hits         7120     7189      +69     
+ Misses       2223     2222       -1     
- Partials      249      254       +5     

@djukicn
Copy link
Collaborator Author

djukicn commented Nov 2, 2021

@PrimozGodec Done.

@PrimozGodec PrimozGodec merged commit b99a1c8 into biolab:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants