Topic Modeling: Base selection style on itemdelegates #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 74.30% 74.48% +0.17%
==========================================
Files 73 74 +1
Lines 9669 9896 +227
Branches 1321 1334 +13
==========================================
+ Hits 7185 7371 +186
- Misses 2229 2269 +40
- Partials 255 256 +1 |
Comment on lines
384
to
385
| painter.setPen( | ||
| QtGui.QPen(text_color_for_state(option.palette, option.state))) |
There was a problem hiding this comment.
This should probably be
ctx.palette.setColor(QtGui.QPalette.Text, text_color_for_state(option.palette, option.state))
ajdapretnar
force-pushed
the
focus-tm
branch
from
28b280b to
bb325aa
Compare
|
This one needs at least orange-widget-base 4.14.0. So we need to increase the minimum version to |
PrimozGodec
approved these changes
Nov 18, 2021
PrimozGodec
force-pushed
the
focus-tm
branch
from
66e9830 to
1a568e0
Compare
…ates summaries but Table not
PrimozGodec
force-pushed
the
focus-tm
branch
from
498bdbd to
f62b8d9
Compare
|
I added two commits to this branch. First increases minimal version of orange-widget-base. The second fixes summary implementation which does not work when a version of orange-widget-base >=4.14 and the version of Orange==3.28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #711.
Description of changes
Use
text_color_for_stateto color selection in Topic Modeling.Includes