[FIX] Semantic search: fix wrong output when response is None #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
fix-semantic-search
branch
from
768fb5d to
a2d247b
Compare
|
@PrimozGodec I think you need to clean this commit history. 😅 |
PrimozGodec
force-pushed
the
fix-semantic-search
branch
from
a2d247b to
a243602
Compare
PrimozGodec
force-pushed
the
fix-semantic-search
branch
from
a243602 to
9d51cb5
Compare
Done, accidentally made a new branch from the wrong branch |
|
We've all been there. |
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
==========================================
+ Coverage 75.87% 76.96% +1.08%
==========================================
Files 78 79 +1
Lines 10622 11441 +819
Branches 1704 1905 +201
==========================================
+ Hits 8059 8805 +746
- Misses 2302 2355 +53
- Partials 261 281 +20 |
PrimozGodec
force-pushed
the
fix-semantic-search
branch
from
57fed39 to
9d51cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Semantic search fail when more than 2 texts are in one chunk and response is None
Description of changes
This PR fixes the fail in the specific case
Also now when the requirement for orange3-text is Orange3>=3.32.0 the callback can be modified to new callback for semantic search.
Includes